Clean status message after leave canvas

[Czaki]

Description

This PR fix lack of update of status bar when mouse leave canvas or dim slider was updated

Type of change

• Bug-fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

References

fix #4606

How has this been tested?

• example: the test suite for my feature covers cases x, y, and z
• example: all tests pass with my change
• example: I check if my changes works with both PySide and PyQt backends
  as there are small differences between the two Qt bindings.

Final checklist:

• My PR is the minimum possible work for the desired functionality
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• If I included new strings, I have used trans. to make them localizable.
  For more information see our translations guide.

[Czaki]

vispy does not provide leave/enter events so there is a need to workaround this.

[psobolewskiPhD]

I like the way the status display works with this PR: showing values if mouseover data, showing coordinates if mouseover canvas, showing nothing if outside canvas.
I think this is intuitive and a nice improvement.

But the other change in behavior is odd? I'm referring to the 2nd issue I mention here:
#4606 (comment)
If the mouse is fixed above a data point, but the slider is moved with arrow keys.
So on live, the status isn't updated at all.
With this PR the value is updated, but not the coordinates; only 1 is changing, that of the slider, the mouse is fixed.

[Czaki]

But the other change in behavior is odd? I'm referring to the 2nd issue I mention here:

Thanks for pointing this out. I focus only on value and forgot about the cursor position. Could you check the current version?

[psobolewskiPhD]

Looks good to me!

I wonder if at the same time we could kill another visual glitch:
With cells3D sample open, hover your mouse in the upper right area of the image.
For example, you will get something like nuclei [30 30 30]: 10000
But now move the mouse to the right half and you will get:
nuclei [ 30 30 120]: 10000
Notice there is a space after the first bracket now!
If you watch while sliding the mouse, you will see the extra space pop up.
Edit: the same thing happens if you move your mouse down in y instead of across in x.
It's minor, but somehow eye-catching and bothersome to me 🤣

[Czaki]

These additional spaces come from this how numpy.ndarray define its __str__ operator. It uses an equal length column. I change the method of print coordinate in the last commit. Could you check?

[psobolewskiPhD]

Looks good on my end!
🙏
(checked with >100 z slices too, also fine)

[codecov]

Codecov Report

Merging #4607 (684c2b2) into main (7b940da) will increase coverage by 1.62%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4607      +/-   ##
==========================================
+ Coverage   84.42%   86.04%   +1.62%     
==========================================
  Files         612      584      -28     
  Lines       51549    50012    -1537     
==========================================
- Hits        43519    43032     -487     
+ Misses       8030     6980    -1050     

Impacted Files	Coverage Δ
napari/_qt/qt_viewer.py	70.24% <100.00%> (+0.54%)	⬆️
napari/_qt/widgets/qt_welcome.py	87.01% <100.00%> (+1.50%)	⬆️
napari/_tests/test_viewer.py	96.04% <100.00%> (+0.02%)	⬆️
napari/components/_tests/test_viewer_model.py	100.00% <100.00%> (ø)
napari/components/viewer_model.py	96.61% <100.00%> (-0.19%)	⬇️
napari/utils/status_messages.py	96.15% <100.00%> (ø)
napari/utils/tree/node.py	84.09% <0.00%> (-15.91%)	⬇️
napari/layers/tracks/_track_utils.py	88.06% <0.00%> (-3.41%)	⬇️
napari/utils/action_manager.py	83.17% <0.00%> (-0.94%)	⬇️
napari/utils/events/containers/_nested_list.py	92.45% <0.00%> (-0.93%)	⬇️
... and 46 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b940da...684c2b2. Read the comment docs.

[alisterburt]

looks good! requested a few minor changes but will be good to get this in, thanks @Czaki and @psobolewskiPhD !

I re-ran CI to see if we can avoid this Qt viewer cleanup thing

[alisterburt]

thanks for that @Czaki - I pushed a few commits fixing some minor typos but otherwise this now looks good to me!

[Czaki]

thanks for that @Czaki - I pushed a few commits with some minor typos but otherwise this now looks good to me!

One remark. There is an option to commit all such changes in one commit (from Files Change view). This will reduce CI usage.

[andy-sweet]

Looks great and works well! I only have a couple of minor comments, though there may be a missing translation here.

Otherwise, I'll likely merge this in the next 24 hours.

[andy-sweet]

Optional: I'm not convinced how useful this is, so I'd consider removing it. But I don't have strong feelings.

If you do want to keep it then I think it should be a translated string right?

[Czaki]

Here is also a lack of translation. Should I replace both places for consistency?

napari/napari/components/viewer_model.py

Line 129 in f3289ac

status: str = 'Ready'

[andy-sweet]

Ah that's where this comes from! Thanks for the pointer!

I think my dream would be to define a constant in viewer_model.py like STATUS_DEFAULT = trans._('Ready'), then use that in both places. What do you think? Even you like it, definitely feel free to write up an issue or do that in a separate PR if you want to get this one in without another change.

[alisterburt]

Thanks @Czaki @andy-sweet ! Merge time