-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Follow Nep29, bump minimum numpy. #5532
Conversation
As usual this is open for discussion. See previous thread in napari#5089. Also add a Nep29 badge to the readme.
remove type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok for me.
As it removes conditional imports it is improvement for me.
As I do not know when the next release will be I'm ok with fast merge.
The ubuntu archive seem to have been down. |
Codecov Report
@@ Coverage Diff @@
## main #5532 +/- ##
=======================================
Coverage 89.40% 89.41%
=======================================
Files 609 609
Lines 51146 51136 -10
=======================================
- Hits 45729 45721 -8
+ Misses 5417 5415 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Minreq failure is unrelated, but maybe this PR could also affect that... maybe we shoudl wait? @Czaki any progress on the minreq issue? |
I have created #5560. My attempt for better solution is here but require time to polish https://github.com/Czaki/tox-min-req |
Tests are good now, let's merge! |
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
As usual this is open for discussion.
See previous thread in #5089.
Also add a Nep29 badge to the readme.
for info Nep29 suggests:
This also remove any conditional branching based on numpy version.
Note that this is technically a change of API ad DTypeLiike is not exposed by
napari.types
anymore. I did not manage to keep it there asruff
is removing is as an unused import. I think that's ok as this was likely only used internally.Type of change
References
https://numpy.org/neps/nep-0029-deprecation_policy.html
Final checklist:
trans.
to make them localizable.For more information see our translations guide.