Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Follow Nep29, bump minimum numpy. #5532

Merged
merged 4 commits into from
Feb 17, 2023
Merged

MAINT: Follow Nep29, bump minimum numpy. #5532

merged 4 commits into from
Feb 17, 2023

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented Feb 6, 2023

As usual this is open for discussion.
See previous thread in #5089.

Also add a Nep29 badge to the readme.

for info Nep29 suggests:

On Jan 31, 2023 drop support for NumPy 1.20 (initially released on Jan 31, 2021)

This also remove any conditional branching based on numpy version.

Note that this is technically a change of API ad DTypeLiike is not exposed by napari.types anymore. I did not manage to keep it there as ruff is removing is as an unused import. I think that's ok as this was likely only used internally.

Type of change

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

References

https://numpy.org/neps/nep-0029-deprecation_policy.html

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

As usual this is open for discussion.
See previous thread in napari#5089.

Also add a Nep29 badge to the readme.
@github-actions github-actions bot added the tests Something related to our tests label Feb 6, 2023
Copy link
Collaborator

@Czaki Czaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok for me.
As it removes conditional imports it is improvement for me.

As I do not know when the next release will be I'm ok with fast merge.

@Carreau
Copy link
Contributor Author

Carreau commented Feb 6, 2023

The ubuntu archive seem to have been down.
GitHub does not seem happy about it and won't let me restart the failing workflow for now... I'll do it later.

@psobolewskiPhD psobolewskiPhD added this to the 0.5.0 milestone Feb 10, 2023
@psobolewskiPhD psobolewskiPhD added the ready to merge Last chance for comments! Will be merged in ~24h label Feb 10, 2023
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #5532 (7cc29e2) into main (6d27f81) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #5532   +/-   ##
=======================================
  Coverage   89.40%   89.41%           
=======================================
  Files         609      609           
  Lines       51146    51136   -10     
=======================================
- Hits        45729    45721    -8     
+ Misses       5417     5415    -2     
Impacted Files Coverage Δ
napari/_tests/utils.py 100.00% <ø> (+2.19%) ⬆️
napari/layers/_data_protocols.py 100.00% <ø> (ø)
napari/components/_tests/test_layer_slicer.py 97.98% <100.00%> (-1.21%) ⬇️
napari/types.py 90.19% <100.00%> (+4.23%) ⬆️
napari/components/experimental/chunk/_pool.py 85.71% <0.00%> (-7.94%) ⬇️
napari/_qt/dialogs/qt_package_installer.py 81.81% <0.00%> (+0.39%) ⬆️
napari/utils/theme.py 94.04% <0.00%> (+0.59%) ⬆️
napari/utils/info.py 85.10% <0.00%> (+1.06%) ⬆️
napari/_qt/__init__.py 56.66% <0.00%> (+6.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@brisvag
Copy link
Contributor

brisvag commented Feb 13, 2023

Minreq failure is unrelated, but maybe this PR could also affect that... maybe we shoudl wait? @Czaki any progress on the minreq issue?

@Czaki
Copy link
Collaborator

Czaki commented Feb 13, 2023

I have created #5560.
I do not like it, but I do not think that I will be able to ship something better in short time.

My attempt for better solution is here but require time to polish https://github.com/Czaki/tox-min-req

@brisvag
Copy link
Contributor

brisvag commented Feb 17, 2023

Tests are good now, let's merge!

@brisvag brisvag merged commit 1477132 into napari:main Feb 17, 2023
@Czaki Czaki removed the ready to merge Last chance for comments! Will be merged in ~24h label Feb 18, 2023
@Czaki Czaki modified the milestones: 0.5.0, 0.4.18 Jun 19, 2023
Czaki pushed a commit that referenced this pull request Jun 19, 2023
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
@Czaki Czaki mentioned this pull request Jun 19, 2023
Czaki pushed a commit that referenced this pull request Jun 21, 2023
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Czaki pushed a commit that referenced this pull request Jun 21, 2023
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Czaki pushed a commit that referenced this pull request Jun 21, 2023
Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
@Carreau Carreau deleted the nep29 branch October 2, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Something related to our tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants