-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix min req #5560
Fix min req #5560
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5560 +/- ##
==========================================
+ Coverage 87.87% 89.38% +1.51%
==========================================
Files 608 608
Lines 51079 51099 +20
==========================================
+ Hits 44885 45675 +790
+ Misses 6194 5424 -770
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
scipy>=1.4.1 ; python_version < '3.9' | ||
scipy>=1.5.4 ; python_version >= '3.9' | ||
sphinx<5 # numpydoc dependency. sphinx>=5 breaks the docs build; see https://github.com/napari/napari/pull/4915 | ||
sphinx>=4.3.0,<5 # numpydoc dependency. sphinx>=5 breaks the docs build; see https://github.com/napari/napari/pull/4915 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, not this PR necessarily, but do we really need this as a napari requirement with the split repo?
I think we should make [docs]
for the docs repo installation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, not this PR necessarily, but do we really need this as a napari requirement with the split repo?
I think we should make[docs]
for the docs repo installation.
No, we could use a constraints file for that. In the next 2-3 days, I may have time to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a docs requirement. Rather, we use numpydocs to move some docstrings around. Run git grep numpydoc
to find where it's used. It might be something we can eventually deprecate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is it that you don't like exactly here?
Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com>
list of indirect napari dependencies that may change on the next dependency release (become obsolete for example). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com>
Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com>
Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com>
Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com>
Description
I do not like this solution, but the proper solution may take a long time so it may be treated as a temporal workaround...
Type of change
References
How has this been tested?
as there are small differences between the two Qt bindings.
Final checklist:
trans.
to make them localizable.For more information see our translations guide.