Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix min req #5560

Merged
merged 5 commits into from
Feb 15, 2023
Merged

Fix min req #5560

merged 5 commits into from
Feb 15, 2023

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Feb 13, 2023

Description

I do not like this solution, but the proper solution may take a long time so it may be treated as a temporal workaround...

Type of change

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

References

How has this been tested?

  • example: the test suite for my feature covers cases x, y, and z
  • example: all tests pass with my change
  • example: I check if my changes works with both PySide and PyQt backends
    as there are small differences between the two Qt bindings.

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

@Czaki Czaki requested a review from brisvag February 13, 2023 17:17
@github-actions github-actions bot added qt Relates to qt tests Something related to our tests labels Feb 13, 2023
@Czaki Czaki added the bugfix PR with bugfix label Feb 13, 2023
@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #5560 (9ada0ba) into main (ada343a) will increase coverage by 1.51%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5560      +/-   ##
==========================================
+ Coverage   87.87%   89.38%   +1.51%     
==========================================
  Files         608      608              
  Lines       51079    51099      +20     
==========================================
+ Hits        44885    45675     +790     
+ Misses       6194     5424     -770     
Impacted Files Coverage Δ
napari/_qt/_tests/test_qt_viewer.py 94.61% <100.00%> (+0.01%) ⬆️
napari/utils/config.py 100.00% <0.00%> (ø)
napari/layers/utils/string_encoding.py 100.00% <0.00%> (ø)
napari/components/experimental/monitor/_api.py 0.00% <0.00%> (ø)
napari/utils/_tests/test_key_bindings.py 96.96% <0.00%> (+0.01%) ⬆️
napari/layers/utils/color_encoding.py 96.20% <0.00%> (+0.04%) ⬆️
napari/_tests/utils.py 97.80% <0.00%> (+0.04%) ⬆️
napari/layers/utils/style_encoding.py 96.22% <0.00%> (+0.07%) ⬆️
napari/layers/shapes/_tests/test_shapes_utils.py 97.22% <0.00%> (+0.07%) ⬆️
napari/_app_model/constants/_menus.py 95.45% <0.00%> (+0.21%) ⬆️
... and 52 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

scipy>=1.4.1 ; python_version < '3.9'
scipy>=1.5.4 ; python_version >= '3.9'
sphinx<5 # numpydoc dependency. sphinx>=5 breaks the docs build; see https://github.com/napari/napari/pull/4915
sphinx>=4.3.0,<5 # numpydoc dependency. sphinx>=5 breaks the docs build; see https://github.com/napari/napari/pull/4915
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, not this PR necessarily, but do we really need this as a napari requirement with the split repo?
I think we should make [docs] for the docs repo installation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, not this PR necessarily, but do we really need this as a napari requirement with the split repo?
I think we should make [docs] for the docs repo installation.

No, we could use a constraints file for that. In the next 2-3 days, I may have time to do that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a docs requirement. Rather, we use numpydocs to move some docstrings around. Run git grep numpydoc to find where it's used. It might be something we can eventually deprecate.

Copy link
Contributor

@brisvag brisvag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is it that you don't like exactly here?

setup.cfg Outdated Show resolved Hide resolved
Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com>
@Czaki
Copy link
Collaborator Author

Czaki commented Feb 14, 2023

What is it that you don't like exactly here?

list of indirect napari dependencies that may change on the next dependency release (become obsolete for example).

Copy link
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Czaki!

As a note: @Czaki and I just had a call where he proposed a way to run the MINREQ tests as using a tox plugin — much more elegant! But this is a good fix in the meantime.

@jni jni added the ready to merge Last chance for comments! Will be merged in ~24h label Feb 14, 2023
@Czaki Czaki merged commit 7d6fc68 into napari:main Feb 15, 2023
@Czaki Czaki deleted the bugfix_min_req_test branch February 15, 2023 18:19
@psobolewskiPhD psobolewskiPhD mentioned this pull request Feb 15, 2023
6 tasks
@Czaki Czaki removed the ready to merge Last chance for comments! Will be merged in ~24h label Feb 18, 2023
@Czaki Czaki mentioned this pull request Jun 7, 2023
@Czaki Czaki added this to the 0.5.0 milestone Jun 16, 2023
@Czaki Czaki added the triaged-0.4.18 To mark PR that is triaged in 0.4.18 release process label Jun 16, 2023
@Czaki Czaki modified the milestones: 0.5.0, 0.4.18 Jun 19, 2023
Czaki added a commit that referenced this pull request Jun 19, 2023
Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com>
Czaki added a commit that referenced this pull request Jun 21, 2023
Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com>
Czaki added a commit that referenced this pull request Jun 21, 2023
Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com>
Czaki added a commit that referenced this pull request Jun 21, 2023
Co-authored-by: Lorenzo Gaifas <brisvag@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR with bugfix qt Relates to qt tests Something related to our tests triaged-0.4.18 To mark PR that is triaged in 0.4.18 release process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants