Add tests/more tests to widgets with low coverage #5864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalthviz
added
tests
Codecov Report
@@ Coverage Diff @@
## main #5864 +/- ##
==========================================
+ Coverage 90.17% 90.26% +0.09%
==========================================
Files 615 617 +2
Lines 51879 51927 +48
==========================================
+ Hits 46782 46874 +92
+ Misses 5097 5053 -44
|
dalthviz
changed the title
kephale
approved these changes
Jun 22, 2023
jni
approved these changes
Jun 22, 2023
melissawm
pushed a commit
to melissawm/napari
that referenced
this pull request
Jul 3, 2023
# Description * [x] Add more tests for `QColorSwatch` related widgets * [x] Add test for `QtToolTipLabel` * [x] Add test for `QtPluginSorter` ## Notes While checking the addition of new tests to widgets using the [code coverage as guidance](https://app.codecov.io/gh/napari/napari/tree/main/napari/_qt/widgets), seems like a widget which doesn't have coverage at all exist: `QtDictTable`. But more interestingly, seems like this widget is not used anymore? I was unable to find a place inside napari source code where this widget is used. Maybe it should be removed or moved to an upstream project like `superqt`?
This was referenced Jul 13, 2023
GenevieveBuckley
pushed a commit
that referenced
this pull request
Aug 1, 2023
# Description Adds a test for the `QtToolTipEventFilter` as a continuation of the effort started at #5864 to increase Qt widgets/code coverage ## Type of change - [x] Tests improvements/additions # How has this been tested? - [x] all tests pass with my change - [x] I check if my changes works with both PySide and PyQt backends as there are small differences between the two Qt bindings. ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality
dstansby
pushed a commit
to dstansby/napari
that referenced
this pull request
Aug 2, 2023
# Description Adds a test for the `QtToolTipEventFilter` as a continuation of the effort started at napari#5864 to increase Qt widgets/code coverage ## Type of change - [x] Tests improvements/additions # How has this been tested? - [x] all tests pass with my change - [x] I check if my changes works with both PySide and PyQt backends as there are small differences between the two Qt bindings. ## Final checklist: - [x] My PR is the minimum possible work for the desired functionality
jni
added a commit
that referenced
this pull request
Aug 19, 2023
# Fixes/Closes closes #6078 # Description Adds some tests to the `ScreenshotDialog` as a continuation of the effort started at #5864 to increase Qt widgets code coverage and fixes some errors with the non-native version (the one used when launching napari from and IPython console) ## Notes and questions * The tests call the dialog `show` method and also sets the non-native option so the tests here only cover the case when napari is being launched from an IPython console. The testing of the OS native version of the dialog is more involved. * Checking the code related with the dialogs available I noticed that some of them (files/widgets classes) have the `qt_*` /`Qt` prefix or the `_dialog`/`Dialog` suffix but others don't (for example `screenshot_dialog.py/ScreenshotDialog` vs `qt_about/QtAbout`). Is that something worthy to standardize or maybe there is already some logic behind the naming? --------- Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com> Co-authored-by: Genevieve Buckley <30920819+GenevieveBuckley@users.noreply.github.com> Co-authored-by: Juan Nunez-Iglesias <jni@fastmail.com> Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Czaki
added a commit
that referenced
this pull request
Oct 17, 2023
# Fixes/Closes closes #6078 # Description Adds some tests to the `ScreenshotDialog` as a continuation of the effort started at #5864 to increase Qt widgets code coverage and fixes some errors with the non-native version (the one used when launching napari from and IPython console) ## Notes and questions * The tests call the dialog `show` method and also sets the non-native option so the tests here only cover the case when napari is being launched from an IPython console. The testing of the OS native version of the dialog is more involved. * Checking the code related with the dialogs available I noticed that some of them (files/widgets classes) have the `qt_*` /`Qt` prefix or the `_dialog`/`Dialog` suffix but others don't (for example `screenshot_dialog.py/ScreenshotDialog` vs `qt_about/QtAbout`). Is that something worthy to standardize or maybe there is already some logic behind the naming? --------- Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com> Co-authored-by: Genevieve Buckley <30920819+GenevieveBuckley@users.noreply.github.com> Co-authored-by: Juan Nunez-Iglesias <jni@fastmail.com> Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
QColorSwatchrelated widgetsQtToolTipLabelQtPluginSorterNotes
While checking the addition of new tests to widgets using the code coverage as guidance, seems like a widget which doesn't have coverage at all exist:
QtDictTable. But more interestingly, seems like this widget is not used anymore? I was unable to find a place inside napari source code where this widget is used. Maybe it should be removed or moved to an upstream project likesuperqt?Type of change
How has this been tested?
as there are small differences between the two Qt bindings.
Final checklist: