Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for QtToolTipEventFilter #6066

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Jul 17, 2023

Description

Adds a test for the QtToolTipEventFilter as a continuation of the effort started at #5864 to increase Qt widgets/code coverage

Type of change

  • Tests improvements/additions

How has this been tested?

  • all tests pass with my change
  • I check if my changes works with both PySide and PyQt backends
    as there are small differences between the two Qt bindings.

Final checklist:

  • My PR is the minimum possible work for the desired functionality

@dalthviz dalthviz added tests Something related to our tests qt Relates to qt maintenance PR with maintance changes, labels Jul 17, 2023
@dalthviz dalthviz self-assigned this Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #6066 (e094330) into main (f8fa80a) will increase coverage by 0.01%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #6066      +/-   ##
==========================================
+ Coverage   91.53%   91.55%   +0.01%     
==========================================
  Files         578      579       +1     
  Lines       50558    50572      +14     
==========================================
+ Hits        46280    46302      +22     
+ Misses       4278     4270       -8     
Files Changed Coverage Δ
napari/_qt/_tests/test_qt_event_filters.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@dalthviz dalthviz marked this pull request as ready for review July 17, 2023 16:41
@Carreau Carreau added this to the 0.5 milestone Jul 18, 2023
@Czaki Czaki modified the milestones: 0.5, 0.5.0 Jul 29, 2023
@Czaki Czaki added the ready to merge Last chance for comments! Will be merged in ~24h label Jul 29, 2023
@GenevieveBuckley
Copy link
Contributor

Thank you @dalthviz 🎉

@GenevieveBuckley GenevieveBuckley merged commit d5be72d into napari:main Aug 1, 2023
36 checks passed
dstansby pushed a commit to dstansby/napari that referenced this pull request Aug 2, 2023
# Description

Adds a test for the `QtToolTipEventFilter` as a continuation of the
effort started at napari#5864 to increase Qt widgets/code coverage

## Type of change
- [x] Tests improvements/additions

# How has this been tested?
- [x] all tests pass with my change
- [x] I check if my changes works with both PySide and PyQt backends
      as there are small differences between the two Qt bindings.  

## Final checklist:
- [x] My PR is the minimum possible work for the desired functionality
@Czaki Czaki removed the ready to merge Last chance for comments! Will be merged in ~24h label Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PR with maintance changes, qt Relates to qt tests Something related to our tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants