Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set removal version in deprecation of Viewer.rounded_division #5944

Merged
merged 1 commit into from
Jun 17, 2023
Merged

Set removal version in deprecation of Viewer.rounded_division #5944

merged 1 commit into from
Jun 17, 2023

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Jun 16, 2023

Description

Fix message about deprecation to inform about removal version.

References

Type of change

  • Documentation

How has this been tested?

  • example: the test suite for my feature covers cases x, y, and z
  • example: all tests pass with my change
  • example: I check if my changes works with both PySide and PyQt backends
    as there are small differences between the two Qt bindings.

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

@Czaki Czaki added this to the 0.4.18 milestone Jun 16, 2023
@Czaki Czaki mentioned this pull request Jun 16, 2023
Closed
@psobolewskiPhD psobolewskiPhD changed the title Fix deprecation message Fix Viewer.rounded_division deprecation message Jun 16, 2023
@Czaki Czaki added the ready to merge Last chance for comments! Will be merged in ~24h label Jun 16, 2023
@jni jni changed the title Fix Viewer.rounded_division deprecation message Set removal version in deprecation of Viewer.rounded_division Jun 17, 2023
@jni jni merged commit c41581c into napari:main Jun 17, 2023
36 checks passed
@jni jni deleted the fix_deprecation branch June 17, 2023 09:14
@Czaki Czaki removed the ready to merge Last chance for comments! Will be merged in ~24h label Jun 17, 2023
Czaki added a commit that referenced this pull request Jun 19, 2023
@Czaki
Set removal version in deprecation of Viewer.rounded_division (#5944)
c7ea6c5 
Change deprecation message of `Viewer.rounded_division` to state
the version in which it will be removed (0.6.0), rather than just a
vague "in the future".
Czaki added a commit that referenced this pull request Jun 21, 2023
@Czaki
Set removal version in deprecation of Viewer.rounded_division (#5944)
191ccc0 
Change deprecation message of `Viewer.rounded_division` to state
the version in which it will be removed (0.6.0), rather than just a
vague "in the future".
Czaki added a commit that referenced this pull request Jun 21, 2023
@Czaki
Set removal version in deprecation of Viewer.rounded_division (#5944)
8e776bd 
Change deprecation message of `Viewer.rounded_division` to state
the version in which it will be removed (0.6.0), rather than just a
vague "in the future".
Czaki added a commit that referenced this pull request Jun 21, 2023
@Czaki
Set removal version in deprecation of Viewer.rounded_division (#5944)
a3541a5 
Change deprecation message of `Viewer.rounded_division` to state
the version in which it will be removed (0.6.0), rather than just a
vague "in the future".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jni jni jni approved these changes

@psobolewskiPhD psobolewskiPhD psobolewskiPhD approved these changes

Assignees

@Czaki Czaki

Labels
documentation
Projects
None yet
Milestone
0.4.18
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Czaki @jni @psobolewskiPhD