Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs using changes from napari/docs #5979

Merged
merged 12 commits into from
Jun 22, 2023
Merged

Update docs using changes from napari/docs #5979

merged 12 commits into from
Jun 22, 2023

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Jun 21, 2023

Description

In this PR, I backport changes from napari/docs repository made after the docs split.

References

Type of change

  • Maintenance (changes required to run napari, tests, & CI smoothly)

How has this been tested?

  • example: the test suite for my feature covers cases x, y, and z
  • example: all tests pass with my change
  • example: I check if my changes works with both PySide and PyQt backends
    as there are small differences between the two Qt bindings.

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

@Czaki Czaki added the maintenance PR with maintance changes, label Jun 21, 2023
@Czaki Czaki added this to the 0.4.18 milestone Jun 21, 2023
@github-actions github-actions bot added documentation tests Something related to our tests qt Relates to qt preferences Issues relating to the creation of new preference fields/panels labels Jun 21, 2023
@Czaki Czaki mentioned this pull request Jun 21, 2023
@kephale kephale changed the title Udpate docs using changes from napari/docs Update docs using changes from napari/docs Jun 22, 2023
Czaki and others added 9 commits June 22, 2023 18:23
# Description
This PR adds documentation for the Shapes layer polygon lasso tool that was added
in napari [#5555](#5555)

## Type of change
- [x] Fixes or improves existing content

# References
depends on #5555

## Final checklist:
- [x] My PR is the minimum possible work for the desired functionality

---------

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
@github-actions github-actions bot removed tests Something related to our tests qt Relates to qt preferences Issues relating to the creation of new preference fields/panels labels Jun 22, 2023
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #5979 (f9fb312) into v0.4.18x (9d81fec) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           v0.4.18x    #5979      +/-   ##
============================================
- Coverage     88.65%   88.63%   -0.02%     
============================================
  Files           620      620              
  Lines         52516    52516              
============================================
- Hits          46559    46550       -9     
- Misses         5957     5966       +9     

see 4 files with indirect coverage changes

@Czaki Czaki merged commit a95393e into v0.4.18x Jun 22, 2023
30 of 31 checks passed
@Czaki Czaki deleted the fix_docs branch June 22, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation maintenance PR with maintance changes,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants