Fix pre-commit configuration #6328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Czaki
commented
Oct 10, 2023
Comment on lines
+24
to
+25
| maintenance: | ||
| - '.pre-commit-config.yaml' |
There was a problem hiding this comment.
As far as I can see, the labeler is fixed and should no longer remove lables.
Also pre-commit do not plan to support labels in it configuration pre-commit-ci/issues#24
brisvag
approved these changes
Oct 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #6328 +/- ##
==========================================
- Coverage 91.98% 91.91% -0.07%
==========================================
Files 595 595
Lines 52586 52586
==========================================
- Hits 48371 48337 -34
- Misses 4215 4249 +34 |
|
Oh, this isn't merged yet; let's get it in! |
brisvag
removed
the
ready to merge
Czaki
added a commit
that referenced
this pull request
Oct 18, 2023
# Description In PR #6328 I have added an automatic maintenance label when something is edited pre-commit. But I wrongly understand actions/lableler documentation and thought that the bug was fixed, that is true, but it is fixed in v5 branch, not backported to v4. v5 has been from a long time (since May) in the release process. actions/labeler#112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stop fixing spaces in vendored modules.
Fix bug pointed in #6318