Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix labeler configuration #6344

Merged
merged 1 commit into from Oct 18, 2023
Merged

Fix labeler configuration #6344

merged 1 commit into from Oct 18, 2023

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Oct 17, 2023

Description

In PR #6328 I have added an automatic maintenance label when something is edited pre-commit. But I wrongly understand actions/lableler documentation and thought that the bug was fixed, that is true, but it is fixed in v5 branch, not backported to v4.

v5 has been from a long time (since May) in the release process.

actions/labeler#112

@Czaki Czaki added this to the 0.5.0 milestone Oct 17, 2023
@github-actions github-actions bot added the task label Oct 17, 2023
@Czaki Czaki added the maintenance PR with maintance changes, label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #6344 (37ef730) into main (591809d) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6344      +/-   ##
==========================================
- Coverage   91.98%   91.91%   -0.07%     
==========================================
  Files         596      596              
  Lines       52644    52644              
==========================================
- Hits        48423    48389      -34     
- Misses       4221     4255      +34     

see 10 files with indirect coverage changes

@Czaki Czaki added the ready to merge Last chance for comments! Will be merged in ~24h label Oct 18, 2023
@Czaki Czaki merged commit efa06ad into napari:main Oct 18, 2023
34 checks passed
@Czaki Czaki deleted the labeler_fix branch October 18, 2023 17:03
@Czaki Czaki removed the ready to merge Last chance for comments! Will be merged in ~24h label Oct 18, 2023
kne42 added a commit to kne42/napari that referenced this pull request Oct 25, 2023
* main: (59 commits)
  Fix permission for JasonEtco/create-an-issue@v2 action (napari#6370)
  Ensure the conda bundle workflows have the appropriate permissions (napari#6379)
  Exclude the loaded property when linking two layers (napari#6377)
  Automatic add `maintenance` label to upgrade dependecies workflow (napari#6371)
  Pydantic 2 compatibility using `pydantic.v1` (napari#6358)
  Update `fsspec`, `imageio`, `magicgui`, `napari-console`, `npe2`, `pillow`, `tensorstore`, `xarray` (napari#6367)
  fix `TransformChain.__getitem__` signature (napari#6369)
  Fix some typing in napari._vispy (napari#6245)
  Fix typing in napari.utils.theme (napari#6247)
  Fix typing in napari.layers.base (napari#6028)
  Fix build wheel workflow file name (napari#6357)
  Fix upstream deprecation: change `np.alltrue` to `np.array_equiv` (napari#6347)
  Add codecov token to reduce propability of fail to upload from main branch (napari#6346)
  Disable ptrace protection to make pytest-pystack work (napari#6343)
  Update example scripts (magicgui with threads) (napari#6353)
  Update `dask`, `hypothesis`, `numpy`, `pillow`, `pretend`, `psutil`, `pyqt5`, `pyqt6`, `pyside6`, `superqt` (napari#6322)
  Add vortex optical flow example (napari#6041)
  Enable memory benchmarks for layers (napari#6295)
  Fix labeler configuration (napari#6344)
  Add 'raise' option back to `strict_qt` in `make_napari_viewer` (napari#6335)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PR with maintance changes, task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants