Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem with invalidate cache #6520

Merged
merged 2 commits into from Dec 11, 2023
Merged

Fix problem with invalidate cache #6520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
524abe2
fix #6518
Czaki Dec 6, 2023
5de4050
add tests
Czaki Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions napari/layers/labels/_tests/test_labels.py
View file
Open in desktop
Expand Up @@ -1639,6 +1639,15 @@ def on_event():
assert event_emitted


def test_invalidate_cache_when_change_slice():
layer = Labels(np.zeros((2, 4, 5), dtype=np.uint8))
assert layer._cached_labels is None
layer._setup_cache(layer._slice.image.raw)
assert layer._cached_labels is not None
layer._set_view_slice()
assert layer._cached_labels is None


class TestLabels:
@staticmethod
def get_objects():
Expand Down
2 changes: 2 additions & 0 deletions napari/layers/labels/labels.py
View file
Open in desktop
Expand Up @@ -1051,8 +1051,10 @@ def _raw_to_displayed(
mapped_labels : array
Encoded colors mapped between 0 and 1 to be displayed.
"""

if data_slice is None:
data_slice = tuple(slice(0, size) for size in raw.shape)
self._cached_labels = None
else:
self._setup_cache(raw)

Expand Down