Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem with invalidate cache #6520

Merged
merged 2 commits into from Dec 11, 2023
Merged

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Dec 7, 2023

References and relevant issues

closes #6518

Description

Fix for #6518 with added tests

@Czaki Czaki added the bugfix PR with bugfix label Dec 7, 2023
@Czaki Czaki added this to the 0.4.19 milestone Dec 7, 2023
@github-actions github-actions bot added the tests Something related to our tests label Dec 7, 2023
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0312cac) 92.25% compared to head (5de4050) 92.21%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6520      +/-   ##
==========================================
- Coverage   92.25%   92.21%   -0.05%     
==========================================
  Files         601      601              
  Lines       53419    53427       +8     
==========================================
- Hits        49284    49266      -18     
- Misses       4135     4161      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Czaki Czaki added the ready to merge Last chance for comments! Will be merged in ~24h label Dec 7, 2023
@GenevieveBuckley GenevieveBuckley merged commit 7810736 into napari:main Dec 11, 2023
37 checks passed
@Czaki Czaki deleted the bugfix/6518_fix branch December 12, 2023 13:58
@Czaki Czaki removed the ready to merge Last chance for comments! Will be merged in ~24h label Dec 12, 2023
Czaki added a commit that referenced this pull request Dec 15, 2023
# References and relevant issues

closes #6518

# Description
Fix for #6518 with added tests
kne42 added a commit to kne42/napari that referenced this pull request Dec 20, 2023
* main: (80 commits)
  Check in LabelColormap that fewer than 2**16 colors are requested (napari#6540)
  Fix label color shuffling by also updating colormap size (napari#6460)
  Add `_block_refresh()` to layers (napari#6525)
  MNT: Use `partial` in samples menu to avoid leaking  (napari#6538)
  Update performance and reduce memory usage for big Labels layer in direct color mode (napari#6439)
  Reset single step and decimals on reset range slider in popup (napari#6523)
  Add copy operator to fix memory benchmarks (napari#6530)
  Restore quit shortcut (napari#6526)
  Fix problem with invalidate cache  (napari#6520)
  [pre-commit.ci] pre-commit autoupdate (napari#6505)
  Pass key event from Main window to our internal mechanism (napari#6419)
  Typing: Fully type 5 more files (napari#6361)
  Do not use native dialog for reset shortcuts (napari#6493)
  Use views rather than CPU-based hashing for 8- and 16-bit Labels data (napari#6467)
  Add import lint back to CI (napari#6506)
  Type napari.layers.image helper sub-modules (napari#6499)
  Bugfix: ensure gamma and opacity are floats (napari#6498)
  FIX: Remove `None` default from `_remove_dock_widget` (napari#6481)
  Add testing_extra and optional dependencies when creating constraints (napari#6487)
  Run test suite with optional dependencies and fix tests when `triangle` is installed (napari#6488)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix PR with bugfix tests Something related to our tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Labels] IndexError after painting into 3D labels layer and toggling 3D
3 participants