Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in shape model name #7166

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Conversation

AJFSalomon
Copy link
Contributor

References and relevant issues

There was a small typo in the filename of one of the shape models.

Description

I fixed it.

@brisvag brisvag added the maintenance PR with maintance changes, label Aug 7, 2024
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (9757590) to head (cf1f28a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7166      +/-   ##
==========================================
- Coverage   92.99%   92.90%   -0.10%     
==========================================
  Files         619      619              
  Lines       56734    56734              
==========================================
- Hits        52761    52708      -53     
- Misses       3973     4026      +53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, that's a good catch!
Thanks! 🙏

@psobolewskiPhD psobolewskiPhD added the ready to merge Last chance for comments! Will be merged in ~24h label Aug 7, 2024
@psobolewskiPhD psobolewskiPhD added this to the 0.5.3 milestone Aug 7, 2024
@jni jni modified the milestones: 0.5.3, 0.5.2 Aug 7, 2024
@brisvag brisvag merged commit dd0a3c6 into napari:main Aug 8, 2024
49 of 50 checks passed
@github-actions github-actions bot removed the ready to merge Last chance for comments! Will be merged in ~24h label Aug 8, 2024
@AJFSalomon AJFSalomon deleted the polygon-typo branch August 8, 2024 15:16
jni pushed a commit that referenced this pull request Aug 12, 2024
# Context
Yup, I know, this is a futile PR. I was bored after work, and after my
last PR (#7166) I thought I would try to find more typos in the repo.
These are clearly not important changes so I don't mind if the PR gets
discarded.

# Description
I've looked for typos in comments and literals, and tried to fix
everything I could find. I'm not 100% sure of all my corrections, so
even if it's just comments, I'd recommend that other contributors check
what I've done before merging. However, I did not look for typos in the
actual code. That's a whole other daunting task I didn't have time for,
sorry.

---------

Co-authored-by: Peter Sobolewski <76622105+psobolewskiPhD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PR with maintance changes,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants