Skip to content

Commit

Permalink
Update typographic errors and explain things in the help messages (#1968
Browse files Browse the repository at this point in the history
)

* Fix typographic error librairy -> library

* Update help message for --debug flag

The message for --debug is not obvious because it doesn't explain that
it enables a different logging scheme (a more verbose log is captured).
Additionally, self-claiming that the program is bug-free is not very
useful when you're debugging a serious bug.
  • Loading branch information
danirod authored and naparuba committed Jul 16, 2019
1 parent 546448a commit 70ce924
Show file tree
Hide file tree
Showing 19 changed files with 31 additions and 31 deletions.
6 changes: 3 additions & 3 deletions bin/shinken-arbiter
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,14 @@ def main():
dest="do_replace",
help="Replace previous running arbiter")
parser.add_option('--debugfile', dest='debug_file',
help=("Debug file. Default: not used "
"(why debug a bug free program? :) )"))
help=("Enable debug log and save it to a file. "
"Default: not used"))
parser.add_option("-v", "--verify-config",
dest="verify_only", action="store_true",
help="Verify config file and exit")
parser.add_option("-p", "--profile",
dest="profile",
help="Dump a profile file. Need the python cProfile librairy")
help="Dump a profile file. Need the python cProfile library")
parser.add_option("-a", "--analyse",
dest="analyse",
help="Dump an analyse statistics file, for support")
Expand Down
6 changes: 3 additions & 3 deletions bin/shinken-broker
Original file line number Diff line number Diff line change
Expand Up @@ -75,11 +75,11 @@ def main():
dest="do_replace",
help="Replace previous running broker")
parser.add_option('--debugfile', dest='debug_file',
help=("Debug file. Default: not used "
"(why debug a bug free program? :) )"))
help=("Enable debug log and save it to a file. "
"Default: not used"))
parser.add_option("-p", "--profile",
dest="profile",
help="Dump a profile file. Need the python cProfile librairy")
help="Dump a profile file. Need the python cProfile library")

opts, args = parser.parse_args()
if args:
Expand Down
6 changes: 3 additions & 3 deletions bin/shinken-poller
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,11 @@ def main():
dest="do_replace",
help="Replace previous running poller")
parser.add_option('--debugfile', dest='debug_file',
help=("Debug file. Default: not used "
"(why debug a bug free program? :) )"))
help=("Enable debug log and save it to a file. "
"Default: not used"))
parser.add_option("-p", "--profile",
dest="profile",
help="Dump a profile file. Need the python cProfile librairy")
help="Dump a profile file. Need the python cProfile library")

opts, args = parser.parse_args()
if args:
Expand Down
6 changes: 3 additions & 3 deletions bin/shinken-reactionner
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,11 @@ def main():
dest="do_replace",
help="Replace previous running reactionner")
parser.add_option('--debugfile', dest='debug_file',
help=("Debug file. Default: not used "
"(why debug a bug free program? :) )"))
help=("Enable debug log and save it to a file. "
"Default: not used"))
parser.add_option("-p", "--profile",
dest="profile",
help="Dump a profile file. Need the python cProfile librairy")
help="Dump a profile file. Need the python cProfile library")

opts, args = parser.parse_args()
if args:
Expand Down
4 changes: 2 additions & 2 deletions bin/shinken-receiver
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ def main():
dest="do_replace",
help="Replace previous running receiver")
parser.add_option('--debugfile', dest='debug_file',
help=("Debug file. Default: not used "
"(why debug a bug free program? :) )"))
help=("Enable debug log and save it to a file. "
"Default: not used"))
opts, args = parser.parse_args()
if args:
parser.error("Does not accept any argument.")
Expand Down
6 changes: 3 additions & 3 deletions bin/shinken-scheduler
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,11 @@ def main():
dest="do_replace",
help="Replace previous running scheduler")
parser.add_option('--debugfile', dest='debug_file',
help=("Debug file. Default: not used "
"(why debug a bug free program? :) )"))
help=("Enable debug log and save it to a file. "
"Default: not used"))
parser.add_option("-p", "--profile",
dest="profile",
help="Dump a profile file. Need the python cProfile librairy")
help="Dump a profile file. Need the python cProfile library")

opts, args = parser.parse_args()
if args:
Expand Down
2 changes: 1 addition & 1 deletion manpages/manpages/shinken-arbiter.8
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ Show program\(aqs version number
Enable debug logging to \fIDEBUGFILE\fP
.TP
.BI \-p \ PROFILE\fP,\fB \ \-\-profile\fB= PROFILE
Dump a profile file. Need the python cProfile librairy
Dump a profile file. Need the python cProfile library
.TP
.BI \-a \ ANALYSE\fP,\fB \ \-\-analyse\fB= ANALYSE
Dump an analyse statistics file, for support
Expand Down
2 changes: 1 addition & 1 deletion manpages/manpages/shinken-broker.8
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ Show program\(aqs version number
Enable debug logging to \fIDEBUGFILE\fP
.TP
.BI \-p \ PROFILE\fP,\fB \ \-\-profile\fB= PROFILE
Dump a profile file. Need the python cProfile librairy
Dump a profile file. Need the python cProfile library
.UNINDENT
.UNINDENT
.UNINDENT
Expand Down
2 changes: 1 addition & 1 deletion manpages/manpages/shinken-poller.8
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Show program\(aqs version number
Enable debug logging to \fIDEBUGFILE\fP
.TP
.BI \-p \ PROFILE\fP,\fB \ \-\-profile\fB= PROFILE
Dump a profile file. Need the python cProfile librairy
Dump a profile file. Need the python cProfile library
.UNINDENT
.UNINDENT
.UNINDENT
Expand Down
2 changes: 1 addition & 1 deletion manpages/manpages/shinken-reactionner.8
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Show program\(aqs version number
Enable debug logging to \fIDEBUGFILE\fP
.TP
.BI \-p \ PROFILE\fP,\fB \ \-\-profile\fB= PROFILE
Dump a profile file. Need the python cProfile librairy
Dump a profile file. Need the python cProfile library
.UNINDENT
.UNINDENT
.UNINDENT
Expand Down
2 changes: 1 addition & 1 deletion manpages/manpages/shinken-receiver.8
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Show program\(aqs version number
Enable debug logging to \fIDEBUGFILE\fP
.TP
.BI \-p \ PROFILE\fP,\fB \ \-\-profile\fB= PROFILE
Dump a profile file. Need the python cProfile librairy
Dump a profile file. Need the python cProfile library
.UNINDENT
.UNINDENT
.UNINDENT
Expand Down
2 changes: 1 addition & 1 deletion manpages/manpages/shinken-scheduler.8
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Show program\(aqs version number
Enable debug logging to \fIDEBUGFILE\fP
.TP
.BI \-p \ PROFILE\fP,\fB \ \-\-profile\fB= PROFILE
Dump a profile file. Need the python cProfile librairy
Dump a profile file. Need the python cProfile library
.UNINDENT
.UNINDENT
.UNINDENT
Expand Down
2 changes: 1 addition & 1 deletion manpages/sources/shinken-arbiter.rst
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ OPTIONS
-h, --help Show this help message
--version Show program's version number
--debugfile=DEBUGFILE Enable debug logging to *DEBUGFILE*
-p PROFILE, --profile=PROFILE Dump a profile file. Need the python cProfile librairy
-p PROFILE, --profile=PROFILE Dump a profile file. Need the python cProfile library
-a ANALYSE, --analyse=ANALYSE Dump an analyse statistics file, for support
-m MIGRATE, --migrate=MIGRATE Migrate the raw configuration read from the arbiter to another module. --> VERY EXPERIMENTAL!
-n ARB_NAME, --name=ARB_NAME Give the arbiter name to use. Optionnal, will use the hostaddress if not provide to find it.
Expand Down
2 changes: 1 addition & 1 deletion manpages/sources/shinken-broker.rst
Original file line number Diff line number Diff line change
Expand Up @@ -45,5 +45,5 @@ OPTIONS
-h, --help Show this help message
--version Show program's version number
--debugfile=DEBUGFILE Enable debug logging to *DEBUGFILE*
-p PROFILE, --profile=PROFILE Dump a profile file. Need the python cProfile librairy
-p PROFILE, --profile=PROFILE Dump a profile file. Need the python cProfile library

2 changes: 1 addition & 1 deletion manpages/sources/shinken-poller.rst
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ OPTIONS
-h, --help Show this help message
--version Show program's version number
--debugfile=DEBUGFILE Enable debug logging to *DEBUGFILE*
-p PROFILE, --profile=PROFILE Dump a profile file. Need the python cProfile librairy
-p PROFILE, --profile=PROFILE Dump a profile file. Need the python cProfile library

2 changes: 1 addition & 1 deletion manpages/sources/shinken-reactionner.rst
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ OPTIONS
-h, --help Show this help message
--version Show program's version number
--debugfile=DEBUGFILE Enable debug logging to *DEBUGFILE*
-p PROFILE, --profile=PROFILE Dump a profile file. Need the python cProfile librairy
-p PROFILE, --profile=PROFILE Dump a profile file. Need the python cProfile library

2 changes: 1 addition & 1 deletion manpages/sources/shinken-receiver.rst
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ OPTIONS
-h, --help Show this help message
--version Show program's version number
--debugfile=DEBUGFILE Enable debug logging to *DEBUGFILE*
-p PROFILE, --profile=PROFILE Dump a profile file. Need the python cProfile librairy
-p PROFILE, --profile=PROFILE Dump a profile file. Need the python cProfile library

2 changes: 1 addition & 1 deletion manpages/sources/shinken-scheduler.rst
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,5 @@ OPTIONS
-h, --help Show this help message
--version Show program's version number
--debugfile=DEBUGFILE Enable debug logging to *DEBUGFILE*
-p PROFILE, --profile=PROFILE Dump a profile file. Need the python cProfile librairy
-p PROFILE, --profile=PROFILE Dump a profile file. Need the python cProfile library

4 changes: 2 additions & 2 deletions shinken/http_daemon.py
Original file line number Diff line number Diff line change
Expand Up @@ -173,9 +173,9 @@ def log_request(*args, **kw):

if use_ssl:
if not ssl:
logger.error("Missing python-openssl librairy,"
logger.error("Missing python-openssl library,"
"please install it to open a https backend")
raise Exception("Missing python-openssl librairy, "
raise Exception("Missing python-openssl library, "
"please install it to open a https backend")
srv.socket = ssl.wrap_socket(srv.socket,
keyfile=ssl_key, certfile=ssl_cert, server_side=True)
Expand Down

0 comments on commit 70ce924

Please sign in to comment.