fix(cli): --features and --no-default-features should not be exclusive

napi-rs · Dec 7, 2023 · f285e11 · f285e11 · github-actions · Dec 7, 2023
1 parent db89395
commit f285e11
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/cli/src/api/build.ts b/cli/src/api/build.ts
@@ -518,11 +518,17 @@ class Builder {
 
   private setFeatures() {
     const args = []
+    if (this.options.allFeatures && this.options.allFeatures) {
+      throw new Error(
+        'Cannot specify --all-features and --no-default-features together',
+      )
+    }
     if (this.options.allFeatures) {
       args.push('--all-features')
     } else if (this.options.noDefaultFeatures) {
       args.push('--no-default-features')
-    } else if (this.options.features) {
+    }
+    if (this.options.features) {
       args.push('--features', ...this.options.features)
     }