Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NapiValue trait functions are unsafe #299

Closed
adumbidiot opened this issue Nov 14, 2020 · 0 comments · Fixed by #309
Closed

NapiValue trait functions are unsafe #299

adumbidiot opened this issue Nov 14, 2020 · 0 comments · Fixed by #309
Labels
good first issue Good for newcomers

Comments

@adumbidiot
Copy link
Collaborator

The NapiTrait functions are unsafe as creating an napi_value from a null pointer, or even a valid pointer to another type is "safe". As such, the from_* methods should be unsafe.
@Brooooooklyn Brooooooklyn added the good first issue Good for newcomers label Nov 16, 2020
Brooooooklyn added a commit that referenced this issue Nov 19, 2020
@Brooooooklyn
refactor(napi): make NapiTrait to be unsafe
781ff8d 
close #299
@Brooooooklyn Brooooooklyn mentioned this issue Nov 19, 2020
Merged
Brooooooklyn added a commit that referenced this issue Feb 7, 2021
@Brooooooklyn
refactor(napi): make NapiTrait to be unsafe
a6d9e1d 
close #299
caixtong pushed a commit to caixtong/napirs that referenced this issue Jun 20, 2022
@Brooooooklyn
refactor(napi): make NapiTrait to be unsafe
7592d2e 
close napi-rs/napi-rs#299
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(napi): CString issues napi-rs/napi-rs
2 participants
@Brooooooklyn @adumbidiot