-
-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Quote toml path #1410
Merged
Merged
[Fix] Quote toml path #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue when tomlPath has a space in it
kodiakhq bot
referenced
this pull request
in X-oss-byte/Canary-nextjs
Sep 25, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@napi-rs/cli](https://togithub.com/napi-rs/napi-rs) | [`2.13.3` -> `2.16.3`](https://renovatebot.com/diffs/npm/@napi-rs%2fcli/2.13.3/2.16.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>napi-rs/napi-rs (@​napi-rs/cli)</summary> ### [`v2.16.3`](https://togithub.com/napi-rs/napi-rs/releases/tag/%40napi-rs/cli%402.16.3) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.16.2...@napi-rs/cli@2.16.3) #### What's Changed - chore: upgrade npm dependencies by [@​Brooooooklyn](https://togithub.com/Brooooooklyn) in [https://github.com/napi-rs/napi-rs/pull/1658](https://togithub.com/napi-rs/napi-rs/pull/1658) - fix(cli): zig 0.11 link args by [@​Brooooooklyn](https://togithub.com/Brooooooklyn) in [https://github.com/napi-rs/napi-rs/pull/1698](https://togithub.com/napi-rs/napi-rs/pull/1698) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/[@​napi-rs/cli](https://togithub.com/napi-rs/cli)[@​2](https://togithub.com/2).16.2...[@​napi-rs/cli](https://togithub.com/napi-rs/cli)[@​2](https://togithub.com/2).16.3 ### [`v2.16.2`](https://togithub.com/napi-rs/napi-rs/releases/tag/%40napi-rs/cli%402.16.2) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.16.1...@napi-rs/cli@2.16.2) #### What's Changed - fix(cli): ts constEnum option not working when set in package.json by [@​pengx17](https://togithub.com/pengx17) in [https://github.com/napi-rs/napi-rs/pull/1647](https://togithub.com/napi-rs/napi-rs/pull/1647) #### New Contributors - [@​pengx17](https://togithub.com/pengx17) made their first contribution in [https://github.com/napi-rs/napi-rs/pull/1647](https://togithub.com/napi-rs/napi-rs/pull/1647) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/[@​napi-rs/cli](https://togithub.com/napi-rs/cli)[@​2](https://togithub.com/2).16.1...[@​napi-rs/cli](https://togithub.com/napi-rs/cli)[@​2](https://togithub.com/2).16.2 ### [`v2.16.1`](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.16.0...@napi-rs/cli@2.16.1) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.16.0...@napi-rs/cli@2.16.1) ### [`v2.16.0`](https://togithub.com/napi-rs/napi-rs/releases/tag/%40napi-rs/cli%402.16.0) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.15.2...@napi-rs/cli@2.16.0) #### What's Changed - feat(cli): support --profile flag by [@​Brooooooklyn](https://togithub.com/Brooooooklyn) napi-rs/napi-rs@dfbe464 **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/[@​napi-rs/cli](https://togithub.com/napi-rs/cli)[@​2](https://togithub.com/2).15.2...[@​napi-rs/cli](https://togithub.com/napi-rs/cli)[@​2](https://togithub.com/2).16.0 ### [`v2.15.2`](https://togithub.com/napi-rs/napi-rs/releases/tag/%40napi-rs/cli%402.15.2) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.15.1...@napi-rs/cli@2.15.2) #### What's Changed - fix(cli,napi-derive): backward compatible with older cli with [#​1531](https://togithub.com/napi-rs/napi-rs/issues/1531) by [@​Brooooooklyn](https://togithub.com/Brooooooklyn) in [https://github.com/napi-rs/napi-rs/pull/1536](https://togithub.com/napi-rs/napi-rs/pull/1536) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi-derive@2.12.1...[@​napi-rs/cli](https://togithub.com/napi-rs/cli)[@​2](https://togithub.com/2).15.2 ### [`v2.15.1`](https://togithub.com/napi-rs/napi-rs/releases/tag/%40napi-rs/cli%402.15.1) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.15.0...@napi-rs/cli@2.15.1) #### What's Changed - fix(cli,napi-derive): re-export types from shared crate by [@​Brooooooklyn](https://togithub.com/Brooooooklyn) in [https://github.com/napi-rs/napi-rs/pull/1531](https://togithub.com/napi-rs/napi-rs/pull/1531) - fix(cli): dts pipe by [@​Brooooooklyn](https://togithub.com/Brooooooklyn) in [https://github.com/napi-rs/napi-rs/pull/1532](https://togithub.com/napi-rs/napi-rs/pull/1532) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi-derive@2.12.0...[@​napi-rs/cli](https://togithub.com/napi-rs/cli)[@​2](https://togithub.com/2).15.1 ### [`v2.15.0`](https://togithub.com/napi-rs/napi-rs/releases/tag/%40napi-rs/cli%402.15.0) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.14.8...@napi-rs/cli@2.15.0) #### What's Changed - fix(cli): export non const enums when generating typedefs by [@​nebarf](https://togithub.com/nebarf) in [https://github.com/napi-rs/napi-rs/pull/1527](https://togithub.com/napi-rs/napi-rs/pull/1527) - fix(napi): ThreadsafeFunctionHandle never being dropped by [@​Brooooooklyn](https://togithub.com/Brooooooklyn) in [https://github.com/napi-rs/napi-rs/pull/1530](https://togithub.com/napi-rs/napi-rs/pull/1530) - feat: export registers in wasm32 target by [@​Brooooooklyn](https://togithub.com/Brooooooklyn) in [https://github.com/napi-rs/napi-rs/pull/1529](https://togithub.com/napi-rs/napi-rs/pull/1529) #### New Contributors - [@​meowtec](https://togithub.com/meowtec) made their first contribution in [https://github.com/napi-rs/napi-rs/pull/1525](https://togithub.com/napi-rs/napi-rs/pull/1525) - [@​nebarf](https://togithub.com/nebarf) made their first contribution in [https://github.com/napi-rs/napi-rs/pull/1527](https://togithub.com/napi-rs/napi-rs/pull/1527) - [@​victorteokw](https://togithub.com/victorteokw) made their first contribution in [https://github.com/napi-rs/napi-rs/pull/1526](https://togithub.com/napi-rs/napi-rs/pull/1526) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi@2.11.4...[@​napi-rs/cli](https://togithub.com/napi-rs/cli)[@​2](https://togithub.com/2).15.0 ### [`v2.14.8`](https://togithub.com/napi-rs/napi-rs/releases/tag/%40napi-rs/cli%402.14.8) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.14.7...@napi-rs/cli@2.14.8) ##### Bug Fixes - **cli:** always generate typedef file even native code never changes ([#​1489](https://togithub.com/napi-rs/napi-rs/issues/1489)) ([7281f53](https://togithub.com/napi-rs/napi-rs/commit/7281f533bd73d6c6255244c9f1556a0e39c47738)) ### [`v2.14.7`](https://togithub.com/napi-rs/napi-rs/releases/tag/%40napi-rs/cli%402.14.7) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.14.6...@napi-rs/cli@2.14.7) ##### Bug Fixes - **cli:** JS bindgen file now respects destDir ([#​1481](https://togithub.com/napi-rs/napi-rs/issues/1481)) ([cb529d2](https://togithub.com/napi-rs/napi-rs/commit/cb529d21cf92dfaa279bfe10dde5ad87441b47ba)) ### [`v2.14.6`](https://togithub.com/napi-rs/napi-rs/releases/tag/%40napi-rs/cli%402.14.6) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.14.5...@napi-rs/cli@2.14.6) **Note:** Version bump only for package [@​napi-rs/cli](https://togithub.com/napi-rs/cli) ### [`v2.14.5`](https://togithub.com/napi-rs/napi-rs/releases/tag/%40napi-rs/cli%402.14.5) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.14.4...@napi-rs/cli@2.14.5) ##### Bug Fixes - **cli:** upload GitHub assets issue ([a302c9c](https://togithub.com/napi-rs/napi-rs/commit/a302c9cb18710d8d71045d11780f09d4eaf1ecde)) ### [`v2.14.4`](https://togithub.com/napi-rs/napi-rs/releases/tag/%40napi-rs/cli%402.14.4) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.14.3...@napi-rs/cli@2.14.4) ##### Bug Fixes - **napi:** build error with zig@0.10.1 ([2f52793](https://togithub.com/napi-rs/napi-rs/commit/2f527938b27074116a89b9248e218a2ed073be34)) ### [`v2.14.3`](https://togithub.com/napi-rs/napi-rs/releases/tag/%40napi-rs/cli%402.14.3) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.14.2...@napi-rs/cli@2.14.3) #### What's Changed - Fix broken zig behaviors by [@​controversial](https://togithub.com/controversial) in [https://github.com/napi-rs/napi-rs/pull/1432](https://togithub.com/napi-rs/napi-rs/pull/1432) #### New Contributors - [@​controversial](https://togithub.com/controversial) made their first contribution in [https://github.com/napi-rs/napi-rs/pull/1432](https://togithub.com/napi-rs/napi-rs/pull/1432) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi@2.10.6...[@​napi-rs/cli](https://togithub.com/napi-rs/cli)[@​2](https://togithub.com/2).14.3 ### [`v2.14.2`](https://togithub.com/napi-rs/napi-rs/releases/tag/%40napi-rs/cli%402.14.2) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.14.1...@napi-rs/cli@2.14.2) #### What's Changed - Fix CARGO env var in `napi build` by [@​overlookmotel](https://togithub.com/overlookmotel) in [https://github.com/napi-rs/napi-rs/pull/1426](https://togithub.com/napi-rs/napi-rs/pull/1426) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi@2.10.5...[@​napi-rs/cli](https://togithub.com/napi-rs/cli)[@​2](https://togithub.com/2).14.2 ### [`v2.14.1`](https://togithub.com/napi-rs/napi-rs/releases/tag/%40napi-rs/cli%402.14.1) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.14.0...@napi-rs/cli@2.14.1) #### What's Changed - \[Fix] Quote toml path by [@​TheBrenny](https://togithub.com/TheBrenny) in [https://github.com/napi-rs/napi-rs/pull/1410](https://togithub.com/napi-rs/napi-rs/pull/1410) - chore(cli): update CI template by [@​Brooooooklyn](https://togithub.com/Brooooooklyn) in [https://github.com/napi-rs/napi-rs/pull/1416](https://togithub.com/napi-rs/napi-rs/pull/1416) #### New Contributors - [@​TheBrenny](https://togithub.com/TheBrenny) made their first contribution in [https://github.com/napi-rs/napi-rs/pull/1410](https://togithub.com/napi-rs/napi-rs/pull/1410) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi@2.10.4...[@​napi-rs/cli](https://togithub.com/napi-rs/cli)[@​2](https://togithub.com/2).14.1 ### [`v2.14.0`](https://togithub.com/napi-rs/napi-rs/releases/tag/%40napi-rs/cli%402.14.0) [Compare Source](https://togithub.com/napi-rs/napi-rs/compare/@napi-rs/cli@2.13.3...@napi-rs/cli@2.14.0) #### What's Changed - feat(cli): `Darwin` universal architecture by [@​skirsdeda](https://togithub.com/skirsdeda) in [https://github.com/napi-rs/napi-rs/pull/1397](https://togithub.com/napi-rs/napi-rs/pull/1397) - feat(cli): add --zig-link-only option by [@​Brooooooklyn](https://togithub.com/Brooooooklyn) in [https://github.com/napi-rs/napi-rs/pull/1400](https://togithub.com/napi-rs/napi-rs/pull/1400) #### New Contributors - [@​skirsdeda](https://togithub.com/skirsdeda) made their first contribution in [https://github.com/napi-rs/napi-rs/pull/1397](https://togithub.com/napi-rs/napi-rs/pull/1397) **Full Changelog**: https://github.com/napi-rs/napi-rs/compare/napi@2.10.3...[@​napi-rs/cli](https://togithub.com/napi-rs/cli)[@​2](https://togithub.com/2).14.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Canary-nextjs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue when tomlPath has a space in it
(N.b. Sorry if I didn't follow a PR template - this was done in the browser)