Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Adding a functional share button #123

Closed
ShivanshAr97 opened this issue Dec 11, 2022 · 26 comments · Fixed by #254
Closed

[FEATURE] Adding a functional share button #123

ShivanshAr97 opened this issue Dec 11, 2022 · 26 comments · Fixed by #254
Assignees
Labels

Comments

@ShivanshAr97
Copy link

ShivanshAr97 commented Dec 11, 2022

Description

I would like to contribute by making a functional share button, clicking on which, we will have options to share the post via Whatsapp, Linkedin, Telegram, etc. having the link of the post and some information about the post.

Screenshots

No response

Additional information

No response

@github-actions
Copy link

Hi there, Thanks a lot for raising the issue, we'll look into it asap. Also please mention if you wish to work on the issue as well so you could be assigned

@ShivanshAr97
Copy link
Author

Hey @narayan954 please assign it to me

@narayan954
Copy link
Owner

Good idea but how'd you get/provide link for a post?

@ShivanshAr97
Copy link
Author

I have not gone through the complete code base but I think there will be an id or post name which is stored which is used for mapping the list of posts. This id can be used as params in the URL.

@narayan954
Copy link
Owner

I have not gone through the complete code base but I think there will be an id or post name which is stored which is used for mapping the list of posts. This id can be used as params in the URL.

Yes, that'll do, currently it's not implemented, would you like to work on this?

@narayan954
Copy link
Owner

Also, there's already a share button commented out in post component, make use of that

@praduman8435
Copy link

hey! I want to work on this

@praduman8435
Copy link

what you want to share through share button

@narayan954
Copy link
Owner

what you want to share through share button

Posts, the share button should link to the exact post

@praduman8435
Copy link

what you want to share through share button

Posts, the share button should link to the exact post

Ok

@praduman8435
Copy link

praduman8435 commented Feb 3, 2023

@narayan954 I have created the button now how can I add social media links to that button suggest me

@narayan954
Copy link
Owner

@narayan954 I have created the button now how can I add social media links to that button suggest me

you can read this conversation, it's mentioned already

@praduman8435
Copy link

Hello @narayan954 I have done most of the work the thing last that remain is how can I find the link of the post that I want to share

@praduman8435
Copy link

please help me

@narayan954
Copy link
Owner

Hello @narayan954 I have done most of the work the thing last that remain is how can I find the link of the post that I want to share

there will be an id which is used for mapping the list of posts. This id can be used as params in the URL. You can share posts with that id as parameter in the URL.

@narayan954
Copy link
Owner

You'll need to configure that route.

@narayan954
Copy link
Owner

Hi @praduman8435 , are you still working?

@narayan954
Copy link
Owner

Please, pick only 1 issue at a time. For now pick the one out of three issues you're assigned currently so I can open them for contributions

@praduman8435
Copy link

Currently I am working on this you can open other two for the contributors

@narayan954
Copy link
Owner

are you working on this? @praduman8435

@praduman8435
Copy link

No, I'm not

@narayan954
Copy link
Owner

No, I'm not

okay thanks for confirming

@Hritik1503
Copy link

I want to work for on this issue under jwoc , please assign me

@narayan954
Copy link
Owner

You can be assigned to only one issue at a time, finish the assigned issue first. Thank you

@narayan954 narayan954 added jwoc and removed iwoc labels Mar 1, 2023
@sarkartanmay393
Copy link
Contributor

@narayan954 Assign me on it under jwoc

@narayan954
Copy link
Owner

@narayan954 Assign me on it under jwoc

Great, go ahead!

@narayan954 narayan954 linked a pull request Mar 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants