Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #123 Feature/ShareButton #254

Merged
merged 9 commits into from
Mar 10, 2023
Merged

Fixes #123 Feature/ShareButton #254

merged 9 commits into from
Mar 10, 2023

Conversation

sarkartanmay393
Copy link
Contributor

Screenvideo

Screen.Recording.2023-03-10.at.11.41.49.AM.mp4

@sarkartanmay393
Copy link
Contributor Author

@narayan954 It's done ✅

@sarkartanmay393 sarkartanmay393 mentioned this pull request Mar 10, 2023
Closed
narayan954
narayan954 requested changes Mar 10, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great,but need to fix those minor stuffs. Also, I'm thinking of converting these chunks of code into separate components. So could you please create a component for this share modal and I'll handle the rest chunk later on. App.js is getting unnecessarily complex for newcomers and separating this logic could help.

src/components/Post.jsx Outdated Show resolved Hide resolved
src/App.jsx Outdated Show resolved Hide resolved
src/App.jsx Outdated Show resolved Hide resolved
@narayan954 narayan954 linked an issue Mar 10, 2023 that may be closed by this pull request
[FEATURE] Adding a functional share button #123
Closed
@sarkartanmay393
Copy link
Contributor Author

@narayan954 Check once more

@narayan954
Copy link
Owner

@narayan954 Check once more

are you sure, you have pushed any changes?

@narayan954
Copy link
Owner

@narayan954 Check once more

are you sure, you have pushed any changes?

I had rebased this branch, maybe that'd the reason

@vercel
Copy link

vercel bot commented Mar 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
dummygram ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 10, 2023 at 7:55PM (UTC)

@vercel vercel bot temporarily deployed to Preview March 10, 2023 19:21 Inactive
@sarkartanmay393
Copy link
Contributor Author

@narayan954 Can you see the changes now ?

@vercel vercel bot temporarily deployed to Preview March 10, 2023 19:32 Inactive
@sarkartanmay393
Copy link
Contributor Author

@narayan954 I can't the vercel deployments.

@narayan954
Copy link
Owner

@narayan954 Can you see the changes now ?

Yes, I can, reviewing it.

@narayan954
Copy link
Owner

@narayan954 I can't c the vercel deployments.

under configuration, I'm a bit lazy you know... :')

narayan954
narayan954 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! :)

@vercel vercel bot temporarily deployed to Preview March 10, 2023 19:55 Inactive
narayan954
narayan954 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@narayan954 narayan954 merged commit 2eed6d2 into narayan954:master Mar 10, 2023
@sarkartanmay393 sarkartanmay393 deleted the feature/ShareButton branch March 11, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
hard
Projects
Dummygram
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Adding a functional share button
2 participants
@sarkartanmay393 @narayan954