-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #123 Feature/ShareButton
#254
Fixes #123 Feature/ShareButton
#254
Conversation
@narayan954 It's done ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great,but need to fix those minor stuffs. Also, I'm thinking of converting these chunks of code into separate components. So could you please create a component for this share modal and I'll handle the rest chunk later on. App.js is getting unnecessarily complex for newcomers and separating this logic could help.
02a74d5
to
bbaadcf
Compare
bbaadcf
to
69a2d0b
Compare
@narayan954 Check once more |
are you sure, you have pushed any changes? |
69a2d0b
to
aa26328
Compare
I had rebased this branch, maybe that'd the reason |
aa26328
to
1423da9
Compare
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@narayan954 Can you see the changes now ? |
@narayan954 I can't the vercel deployments. |
Yes, I can, reviewing it. |
under configuration, I'm a bit lazy you know... :') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Screenvideo
Screen.Recording.2023-03-10.at.11.41.49.AM.mp4