Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Update feature for Posts #151

Closed
narayan954 opened this issue Feb 4, 2023 · 21 comments · Fixed by #356
Closed

[FEATURE] Update feature for Posts #151

narayan954 opened this issue Feb 4, 2023 · 21 comments · Fixed by #356
Assignees
@abhishek3434
Labels
medium

Comments

@narayan954
Copy link
Owner

Description

Post owners can update their post's caption.

Screenshots

No response

Additional information

Can be further advanced to updating post's content as well.
@Biswajit-Behera
Copy link

I want to work on this issue under JWOC!

@anvig29
Copy link

anvig29 commented Feb 14, 2023

I want to work on this issue under JWOC

@narayan954
Copy link
Owner Author

@Biswajit-Behera go ahead!

@Biswajit-Behera
Copy link

@Biswajit-Behera go ahead!
Thank You!
Will give you the updates and Will ask if I have any doubts.

@narayan954
Copy link
Owner Author

I want to work on this issue under JWOC

Sorry @anvi2901 , he claimed it first :/

@narayan954
Copy link
Owner Author

@narayan954 will add delete and Save features on the post. Give me some time to create a Pull Request, I will do as soon as possible.

Fine, but save feature is a separate issue and delete feature is already implemented.

Biswajit-Behera added a commit to Biswajit-Behera/dummygram that referenced this issue Feb 17, 2023
@Biswajit-Behera
Add follow and save botton for the given [FEATURE] Update feature for…
e3976b6 
… Posts narayan954#151
@Biswajit-Behera Biswajit-Behera mentioned this issue Feb 17, 2023
Closed
@Biswajit-Behera
Copy link

@narayan954 pushed my PR for #173 for this issue
Added follow button and save button
created FollowerUser and save_post function but its not functioning due to some error.

@narayan954
Copy link
Owner Author

@narayan954 pushed my PR for #173 for this issue Added follow button and save button created FollowerUser and save_post function but its not functioning due to some error.

okay, looking into it

@narayan954
Copy link
Owner Author

@narayan954 pushed my PR for #173 for this issue Added follow button and save button created FollowerUser and save_post function but its not functioning due to some error.

@Biswajit-Behera this issue was to add update feature for caption a user puts on his post. Caption is the text that goes under the post. You just had to implement an updation function for caption using the post id. Also, updation had to be done by the same user who created the post, just like the delete option for post.
But you didn't do any of this. Please try to understand the issue first.

@Biswajit-Behera
Copy link

@narayan954 pushed my PR for #173 for this issue Added follow button and save button created FollowerUser and save_post function but its not functioning due to some error.

@Biswajit-Behera this issue was to add update feature for caption a user puts on his post. Caption is the text that goes under the post. You just had to implement an updation function for caption using the post id. Also, updation had to be done by the same user who created the post, just like the delete option for post. But you didn't do any of this. Please try to understand the issue first.

Sorry for the inaccuracy.
Will do it according to the instructions.

@narayan954
Copy link
Owner Author

@narayan954 pushed my PR for #173 for this issue Added follow button and save button created FollowerUser and save_post function but its not functioning due to some error.

@Biswajit-Behera this issue was to add update feature for caption a user puts on his post. Caption is the text that goes under the post. You just had to implement an updation function for caption using the post id. Also, updation had to be done by the same user who created the post, just like the delete option for post. But you didn't do any of this. Please try to understand the issue first.

Sorry for the inaccuracy.
Will do it according to the instructions.

it's okay ,thanks for understanding :)

@Biswajit-Behera
Copy link

@narayan954 pushed my PR for #173 for this issue Added follow button and save button created FollowerUser and save_post function but its not functioning due to some error.

@Biswajit-Behera this issue was to add update feature for caption a user puts on his post. Caption is the text that goes under the post. You just had to implement an updation function for caption using the post id. Also, updation had to be done by the same user who created the post, just like the delete option for post. But you didn't do any of this. Please try to understand the issue first.

Sorry for the inaccuracy.
Will do it according to the instructions.

it's okay ,thanks for understanding :)

I will give you the updates ASAP!

@narayan954
Copy link
Owner Author

unassigned for no activity

@Bharadwajshivam28
Copy link

@narayan954 Assign to me

@narayan954
Copy link
Owner Author

@narayan954 Assign to me

Go ahead!

@Bharadwajshivam28
Copy link

@narayan954 Assign to me

Go ahead!

Thanks

@abhishek3434
Copy link
Contributor

@narayan954 Please assign this to me under GSSOC

@abhishek3434
Copy link
Contributor

abhishek3434 commented May 20, 2023 •
edited
Loading

@narayan954 Please see these screenshots for Update Caption.
Shall I create a pull request?

Screenshot from 2023-05-21 03-15-02
Screenshot from 2023-05-21 03-15-41
Screenshot from 2023-05-21 03-15-52

@narayan954
Copy link
Owner Author

@narayan954 Please see these screenshots for Update Caption. Shall I create a pull request?

Screenshot from 2023-05-21 03-15-02 Screenshot from 2023-05-21 03-15-41 Screenshot from 2023-05-21 03-15-52

This looks right! you may add the PR, but please allow some time for the PR to be reviewed and merged as currently mentors haven't been on-boarded to the project.

Thank you!

@abhishek3434 abhishek3434 mentioned this issue May 21, 2023
Closed
@abhishek3434
Copy link
Contributor

@narayan954
I am getting these many additions and deletions while creating pull request do you have any solution for this

Screenshot from 2023-05-25 11-54-12

@abhishek3434 abhishek3434 mentioned this issue May 26, 2023
Merged
@narayan954 narayan954 linked a pull request May 26, 2023 that will close this issue
Update feature for Posts #151 #356
Merged
narayan954 added a commit that referenced this issue May 26, 2023
@narayan954
Merge pull request #356 from abhishek3434/update-feature-post
13c6e76 
Update feature for Posts #151
narayan954 added a commit to aadityadike/dummygram that referenced this issue May 26, 2023
@narayan954
Squashed commit of the following:
5d370b6 
commit 73cfb10
Merge: 13c6e76 da50a36
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Fri May 26 23:44:24 2023 +0530

    Merge pull request narayan954#357 from Sriparno08/fix-text

    Fix Grammar in README

commit da50a36
Author: Sriparno Roy <89148144+Sriparno08@users.noreply.github.com>
Date:   Fri May 26 23:21:29 2023 +0530

    Fix punctuation in README

commit 52c2e9c
Author: Sriparno Roy <89148144+Sriparno08@users.noreply.github.com>
Date:   Fri May 26 10:59:47 2023 +0530

    Fix Grammar in README

commit 13c6e76
Merge: d7d0ef8 8eb23b7
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Fri May 26 23:41:33 2023 +0530

    Merge pull request narayan954#356 from abhishek3434/update-feature-post

    Update feature for Posts narayan954#151

commit 8eb23b7
Merge: 2425023 99ff732
Author: Abhishek Joshi <abhishekjoshi433@gmail.com>
Date:   Fri May 26 10:54:17 2023 +0530

    Edit Post caption Fixed

commit 99ff732
Merge: 3e8b722 d7d0ef8
Author: Abhishek Joshi <38461721+abhishek3434@users.noreply.github.com>
Date:   Fri May 26 10:35:14 2023 +0530

    Merge branch 'narayan954:master' into master

commit d7d0ef8
Merge: bda908b 68139c5
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Fri May 26 02:36:13 2023 +0530

    Merge pull request narayan954#353 from narayan954/deepsource-transform-b884f5ab

    format code with prettier

commit 68139c5
Author: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Date:   Thu May 25 20:43:39 2023 +0000

    style: format code with prettier

    Format code with prettier

    This commit fixes the style issues introduced in bda908b according to the output
    from prettier.

    Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/42559a63-d64c-426f-87b3-c6e15a54ad88/

commit bda908b
Merge: d887609 aebedba
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Fri May 26 02:13:18 2023 +0530

    Merge pull request narayan954#347 from Gurmeet-Singh657/issue-Number-#330

    Centralise the Caption , Variable Size Post Shifting Fixing , Name fo…

commit aebedba
Author: Gurmeet <gurmeetsingh222003@gmail.com>
Date:   Thu May 25 15:54:31 2023 +0530

    Centralise the Caption , Variable Size Post Shifting Fixing , Name for Caption Should not be repeated Done

commit d887609
Merge: c544a1e 109ef31
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Fri May 26 01:51:11 2023 +0530

    Merge pull request narayan954#335 from Lakshyyaa/homepg

    Home Page navigation fixed issue narayan954#316

commit 109ef31
Author: Lakshya Singh <lakshyaasin@gmail.com>
Date:   Thu May 25 13:14:11 2023 +0530

    navigation simpler

commit 2425023
Author: Abhishek Joshi <abhishekjoshi433@gmail.com>
Date:   Thu May 25 11:39:36 2023 +0530

    Updated and formated Edit caption

commit 23906ae
Author: Abhishek Joshi <abhishekjoshi433@gmail.com>
Date:   Thu May 25 11:22:46 2023 +0530

    Update Feature post

commit 3068041
Author: Abhishek Joshi <abhishekjoshi433@gmail.com>
Date:   Thu May 25 10:48:52 2023 +0530

    Merge Conflict Resolved and Removed extra code

commit 625ce2f
Author: Lakshya Singh <lakshyaasin@gmail.com>
Date:   Wed May 24 20:22:38 2023 +0530

    homepg naviagtion fixed

commit 6b44fbb
Author: Lakshya Singh <lakshyaasin@gmail.com>
Date:   Wed May 24 15:37:14 2023 +0530

    logo clicking navigation corrected and made uniform

commit 3e8b722
Merge: e3d027e c544a1e
Author: Abhishek Joshi <38461721+abhishek3434@users.noreply.github.com>
Date:   Thu May 25 01:55:35 2023 +0530

    Merge branch 'narayan954:master' into master

commit f4cfe94
Author: Abhishek Joshi <abhishekjoshi433@gmail.com>
Date:   Thu May 25 01:38:18 2023 +0530

    Duplicate code and merge conflict resolve

commit e3d027e
Merge: 20c77bb cb14f8e
Author: Abhishek Joshi <38461721+abhishek3434@users.noreply.github.com>
Date:   Wed May 24 23:33:54 2023 +0530

    Merge branch 'narayan954:master' into master

commit 20c77bb
Merge: 144b05e 4048e40
Author: Abhishek Joshi <38461721+abhishek3434@users.noreply.github.com>
Date:   Wed May 24 00:55:17 2023 +0530

    Merge branch 'narayan954:master' into master

commit bbfd60f
Author: Abhishek Joshi <abhishekjoshi433@gmail.com>
Date:   Wed May 24 00:51:59 2023 +0530

    Updated Features Code Formated

commit 144b05e
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Mon May 22 00:01:02 2023 +0530

    add quick local setup video demonstration

commit 9e75245
Author: Abhishek Joshi <abhishekjoshi433@gmail.com>
Date:   Sun May 21 03:35:25 2023 +0530

    Update Post Caption
@narayan954
Copy link
Owner Author

@narayan954 I am getting these many additions and deletions while creating pull request do you have any solution for this

Screenshot from 2023-05-25 11-54-12

sorry I didn't see this comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhishek3434 abhishek3434

Labels
medium
Projects
Dummygram
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update feature for Posts #151 abhishek3434/dummygram
5 participants
@abhishek3434 @narayan954 @Biswajit-Behera @anvig29 @Bharadwajshivam28