Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Home Page navigation fixed issue #316 #335

Merged
merged 3 commits into from
May 25, 2023
Merged

Home Page navigation fixed issue #316 #335

merged 3 commits into from
May 25, 2023

Conversation

Lakshyyaa
Copy link
Contributor

fixed issue #316

narayan954
narayan954 requested changes May 24, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix that

src/App.jsx Outdated Show resolved Hide resolved
@Lakshyyaa Lakshyyaa requested a review from narayan954 May 25, 2023 10:56
@narayan954 narayan954 linked an issue May 25, 2023 that may be closed by this pull request
Clicking on logo redirects to an empty blank homescreen #316
Closed
narayan954
narayan954 approved these changes May 25, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me for now, but actually this implementation is incomplete and hard-coded. Need to fix it with a better approach later

@narayan954 narayan954 merged commit d887609 into narayan954:master May 25, 2023
narayan954 added a commit to aadityadike/dummygram that referenced this pull request May 26, 2023
@narayan954
Squashed commit of the following:
5d370b6 
commit 73cfb10
Merge: 13c6e76 da50a36
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Fri May 26 23:44:24 2023 +0530

    Merge pull request narayan954#357 from Sriparno08/fix-text

    Fix Grammar in README

commit da50a36
Author: Sriparno Roy <89148144+Sriparno08@users.noreply.github.com>
Date:   Fri May 26 23:21:29 2023 +0530

    Fix punctuation in README

commit 52c2e9c
Author: Sriparno Roy <89148144+Sriparno08@users.noreply.github.com>
Date:   Fri May 26 10:59:47 2023 +0530

    Fix Grammar in README

commit 13c6e76
Merge: d7d0ef8 8eb23b7
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Fri May 26 23:41:33 2023 +0530

    Merge pull request narayan954#356 from abhishek3434/update-feature-post

    Update feature for Posts narayan954#151

commit 8eb23b7
Merge: 2425023 99ff732
Author: Abhishek Joshi <abhishekjoshi433@gmail.com>
Date:   Fri May 26 10:54:17 2023 +0530

    Edit Post caption Fixed

commit 99ff732
Merge: 3e8b722 d7d0ef8
Author: Abhishek Joshi <38461721+abhishek3434@users.noreply.github.com>
Date:   Fri May 26 10:35:14 2023 +0530

    Merge branch 'narayan954:master' into master

commit d7d0ef8
Merge: bda908b 68139c5
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Fri May 26 02:36:13 2023 +0530

    Merge pull request narayan954#353 from narayan954/deepsource-transform-b884f5ab

    format code with prettier

commit 68139c5
Author: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Date:   Thu May 25 20:43:39 2023 +0000

    style: format code with prettier

    Format code with prettier

    This commit fixes the style issues introduced in bda908b according to the output
    from prettier.

    Details: https://app.deepsource.com/gh/narayan954/dummygram/transform/42559a63-d64c-426f-87b3-c6e15a54ad88/

commit bda908b
Merge: d887609 aebedba
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Fri May 26 02:13:18 2023 +0530

    Merge pull request narayan954#347 from Gurmeet-Singh657/issue-Number-#330

    Centralise the Caption , Variable Size Post Shifting Fixing , Name fo…

commit aebedba
Author: Gurmeet <gurmeetsingh222003@gmail.com>
Date:   Thu May 25 15:54:31 2023 +0530

    Centralise the Caption , Variable Size Post Shifting Fixing , Name for Caption Should not be repeated Done

commit d887609
Merge: c544a1e 109ef31
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Fri May 26 01:51:11 2023 +0530

    Merge pull request narayan954#335 from Lakshyyaa/homepg

    Home Page navigation fixed issue narayan954#316

commit 109ef31
Author: Lakshya Singh <lakshyaasin@gmail.com>
Date:   Thu May 25 13:14:11 2023 +0530

    navigation simpler

commit 2425023
Author: Abhishek Joshi <abhishekjoshi433@gmail.com>
Date:   Thu May 25 11:39:36 2023 +0530

    Updated and formated Edit caption

commit 23906ae
Author: Abhishek Joshi <abhishekjoshi433@gmail.com>
Date:   Thu May 25 11:22:46 2023 +0530

    Update Feature post

commit 3068041
Author: Abhishek Joshi <abhishekjoshi433@gmail.com>
Date:   Thu May 25 10:48:52 2023 +0530

    Merge Conflict Resolved and Removed extra code

commit 625ce2f
Author: Lakshya Singh <lakshyaasin@gmail.com>
Date:   Wed May 24 20:22:38 2023 +0530

    homepg naviagtion fixed

commit 6b44fbb
Author: Lakshya Singh <lakshyaasin@gmail.com>
Date:   Wed May 24 15:37:14 2023 +0530

    logo clicking navigation corrected and made uniform

commit 3e8b722
Merge: e3d027e c544a1e
Author: Abhishek Joshi <38461721+abhishek3434@users.noreply.github.com>
Date:   Thu May 25 01:55:35 2023 +0530

    Merge branch 'narayan954:master' into master

commit f4cfe94
Author: Abhishek Joshi <abhishekjoshi433@gmail.com>
Date:   Thu May 25 01:38:18 2023 +0530

    Duplicate code and merge conflict resolve

commit e3d027e
Merge: 20c77bb cb14f8e
Author: Abhishek Joshi <38461721+abhishek3434@users.noreply.github.com>
Date:   Wed May 24 23:33:54 2023 +0530

    Merge branch 'narayan954:master' into master

commit 20c77bb
Merge: 144b05e 4048e40
Author: Abhishek Joshi <38461721+abhishek3434@users.noreply.github.com>
Date:   Wed May 24 00:55:17 2023 +0530

    Merge branch 'narayan954:master' into master

commit bbfd60f
Author: Abhishek Joshi <abhishekjoshi433@gmail.com>
Date:   Wed May 24 00:51:59 2023 +0530

    Updated Features Code Formated

commit 144b05e
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Mon May 22 00:01:02 2023 +0530

    add quick local setup video demonstration

commit 9e75245
Author: Abhishek Joshi <abhishekjoshi433@gmail.com>
Date:   Sun May 21 03:35:25 2023 +0530

    Update Post Caption
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
codepeak level1
Projects
Dummygram
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking on logo redirects to an empty blank homescreen
2 participants
@Lakshyyaa @narayan954