Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shimmer in dark mode and also add it on profile feed #1156

Merged
merged 11 commits into from
Aug 22, 2023

Conversation

Palakkgoyal
Copy link
Contributor

This PR closes #1082
I have fixed the shimmer effect on darkmode and also added in on the profile feed.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Palakkgoyal there seems to be repetition of lots of code, if it seems feasible,can you try something like

function FeedSkeleton() {
  const numSkeletons = 4;

  return (
    <>
      {Array.from({ length: numSkeletons }, (_, index) => (
        <Skeleton
          key={index}
          variant="rectangular"
          style={{
            width: "100%",
            height: "100%",
            aspectRatio: "1",
          }}
          className="shimmer_bg"
        />
      ))}
    </>
  );
}

src/pages/Profile/feed/index.jsx Outdated Show resolved Hide resolved
src/reusableComponents/PostSkeleton/index.jsx Outdated Show resolved Hide resolved
@Palakkgoyal
Copy link
Contributor Author

Yes, sure. I will fix that.

@narayan954 narayan954 marked this pull request as draft August 8, 2023 18:25
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 marked this pull request as ready for review August 22, 2023 09:35
@narayan954 narayan954 merged commit 5b822cd into narayan954:master Aug 22, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shimmer on dark mode
2 participants