-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shimmer in dark mode and also add it on profile feed #1156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Palakkgoyal there seems to be repetition of lots of code, if it seems feasible,can you try something like
function FeedSkeleton() {
const numSkeletons = 4;
return (
<>
{Array.from({ length: numSkeletons }, (_, index) => (
<Skeleton
key={index}
variant="rectangular"
style={{
width: "100%",
height: "100%",
aspectRatio: "1",
}}
className="shimmer_bg"
/>
))}
</>
);
}
Yes, sure. I will fix that. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
This PR closes #1082
I have fixed the shimmer effect on darkmode and also added in on the profile feed.