-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated like button #192
updated like button #192
Conversation
Screencast.from.2023-02-22.14-19-40.webm@narayan954 I have updated the like button please merge my pr. |
@narayan954 please review and merge my pr |
I noticed that you merged the master branch with my pull request #187. I'm wondering if this means that my pull request will still be merged or not. Could you please explain the situation to me? If my pull request isn't going to be merged, then I won't receive any points for it. Can you please help me out with this? Thank you. |
I was just updating this branch with master, it doesn't have anything to do with my decision of merging this pr or not, I am going to review this pr and merge it if it's eligible. Don't worry, you'll receive points for your work! :) |
You didn't change your branch, and worked on your previous branch only that's why you're getting confused, please work on separate branch for separate issue, so to avoid confusions and conflicts in the future, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Okay sir I will keep this in mind :) |
No description provided.