Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated like button #192

Merged
merged 5 commits into from
Feb 23, 2023
Merged

updated like button #192

merged 5 commits into from
Feb 23, 2023

Conversation

1010varun
Copy link
Contributor

No description provided.

@1010varun
Copy link
Contributor Author

Screencast.from.2023-02-22.14-19-40.webm

@narayan954 I have updated the like button please merge my pr.

@1010varun
Copy link
Contributor Author

@narayan954 please review and merge my pr

@1010varun
Copy link
Contributor Author

@narayan954,

I noticed that you merged the master branch with my pull request #187. I'm wondering if this means that my pull request will still be merged or not. Could you please explain the situation to me?

If my pull request isn't going to be merged, then I won't receive any points for it. Can you please help me out with this?

Thank you.

@narayan954
Copy link
Owner

@narayan954,

I noticed that you merged the master branch with my pull request #187. I'm wondering if this means that my pull request will still be merged or not. Could you please explain the situation to me?

If my pull request isn't going to be merged, then I won't receive any points for it. Can you please help me out with this?

Thank you.

I was just updating this branch with master, it doesn't have anything to do with my decision of merging this pr or not, I am going to review this pr and merge it if it's eligible. Don't worry, you'll receive points for your work! :)

@narayan954
Copy link
Owner

narayan954 commented Feb 23, 2023

You didn't change your branch, and worked on your previous branch only that's why you're getting confused, please work on separate branch for separate issue, so to avoid confusions and conflicts in the future,
Thanks

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 linked an issue Feb 23, 2023 that may be closed by this pull request
@narayan954 narayan954 merged commit 6c1ac2a into narayan954:master Feb 23, 2023
@1010varun
Copy link
Contributor Author

You didn't change your branch, and worked on your previous branch only that's why you're getting confused, please work on separate branch for separate issue, so to avoid confusions and conflicts in the future,
Thanks

Okay sir I will keep this in mind :)
Thank you sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] <Enhanced like button>
2 participants