Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SignUp #247 #252

Merged
merged 8 commits into from
Mar 10, 2023
Merged

Fix SignUp #247 #252

merged 8 commits into from
Mar 10, 2023

Conversation

Vineet-Singh-Chauhan
Copy link
Contributor

Fixed issue SignUp #247

github-actions[bot]
github-actions bot reviewed Mar 9, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

narayan954
narayan954 requested changes Mar 10, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right, but still things are off and neither username is updated, nor success snackbar is seen, which explains it. I'll take more look into this soon. Can you try as well for a succesfull signup. The confirmation can be seen via a comment or a new post.

@Vineet-Singh-Chauhan
Copy link
Contributor Author

Screenshot (68)
Screenshot (67)
Screenshot (65)

Screenshot (69)

@Vineet-Singh-Chauhan
Copy link
Contributor Author

Vineet-Singh-Chauhan commented Mar 10, 2023 •
edited
Loading

username is being showed in comment section as well as in post . i have also added snackbar confirmation containing username
@narayan954 can you tell me exactly what is to be done apart from this ??

@narayan954
Copy link
Owner

username is being showed in comment section as well as in post . i have also added snackbar confirmation containing username @narayan954 can you tell me exactly what is to be done apart from this ??

I think we're good then, will take a look and merge the pr, thank you :)

@narayan954 narayan954 linked an issue Mar 10, 2023 that may be closed by this pull request
Fix SignUp #247
Closed
narayan954
narayan954 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 54ef1c2 into narayan954:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
medium
Projects
Dummygram
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix SignUp
2 participants
@Vineet-Singh-Chauhan @narayan954