Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SignUp #247

Closed
narayan954 opened this issue Mar 6, 2023 · 2 comments · Fixed by #252
Closed

Fix SignUp #247

narayan954 opened this issue Mar 6, 2023 · 2 comments · Fixed by #252
Assignees
@Vineet-Singh-Chauhan
Labels
bug level3 medium

Comments

@narayan954
Copy link
Owner

Description

Sign Up functionality is not working correctly!
No snackbar error(except some validations like email already in use etc) or confirmation of sign up success, username not updated for the user and user is defaulting to a null username. Null users are dangerous for the application and can crash it.

Steps to reproduce

Any signup attempt can cause this.

Screenshots

No response

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional information

Opening this to the contributors for a short time as it's a critical issue. Might fix myself if issue goes unattended.
@Vineet-Singh-Chauhan
Copy link
Contributor

Please assign this issue to me under jwoc 2023

@narayan954
Copy link
Owner Author

Great, go ahead! @Vineet-Singh-Chauhan :)

Vineet-Singh-Chauhan added a commit to Vineet-Singh-Chauhan/dummygram that referenced this issue Mar 9, 2023
@Vineet-Singh-Chauhan
Fix SignUp narayan954#247
57ab91a
@Vineet-Singh-Chauhan Vineet-Singh-Chauhan mentioned this issue Mar 9, 2023
Merged
narayan954 pushed a commit to Vineet-Singh-Chauhan/dummygram that referenced this issue Mar 10, 2023
@Vineet-Singh-Chauhan @narayan954
Fix SignUp narayan954#247
312f7bb
@narayan954 narayan954 linked a pull request Mar 10, 2023 that will close this issue
Fix SignUp #247 #252
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vineet-Singh-Chauhan Vineet-Singh-Chauhan

Labels
bug level3 medium
Projects
Dummygram
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix SignUp #247 Vineet-Singh-Chauhan/dummygram
2 participants
@narayan954 @Vineet-Singh-Chauhan