Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue of Outside Clicking on Opening Profile Panel #329

Merged
merged 2 commits into from
May 24, 2023

Conversation

Gurmeet-Singh657
Copy link
Contributor

Hey
I fixed this issue where on Clicking this profile panel box remains open.
But now it will automatically close if the user clicks outside that panel.
Please merge my Pull request.
Thank You
image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954
Copy link
Owner

Please mention the issue number you solved on the pr itself, it helps manage the issue well

@narayan954 narayan954 merged commit 365703f into narayan954:master May 24, 2023
@Gurmeet-Singh657
Copy link
Contributor Author

Sure 👍 Issue Number 318

@narayan954
Copy link
Owner

Sure +1 Issue Number 318

yes please mention these in upcoming prs as well

@narayan954
Copy link
Owner

Thanks for your contribution

@Gurmeet-Singh657
Copy link
Contributor Author

I am grateful to get the opportunity to contribute to your repo 🙂 ✨

@narayan954 narayan954 added level2 and removed level1 labels Jun 20, 2023
@narayan954
Copy link
Owner

upgraded the level

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Clicking on Profile Icon and after that clicking on page , profile and logout bar remains as it is
2 participants