Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#277 Alert updated #441

Merged
merged 4 commits into from
Jun 6, 2023
Merged

issue#277 Alert updated #441

merged 4 commits into from
Jun 6, 2023

Conversation

isha-73
Copy link
Contributor

@isha-73 isha-73 commented Jun 5, 2023

Error alert has been updated!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

src/pages/Login.jsx Outdated Show resolved Hide resolved
src/pages/Login.jsx Outdated Show resolved Hide resolved
src/pages/Login.jsx Outdated Show resolved Hide resolved
src/pages/Login.jsx Outdated Show resolved Hide resolved
@narayan954
Copy link
Owner

Error alert has been updated!

Which issue is this?? Please create an issue to link to a pull request if it doesn't exists

@narayan954
Copy link
Owner

Also, for this issue, I'd suggest you to go through the types of errors Firebase generates for those functions, so you can come to a concluding generic message easily.

@isha-73
Copy link
Contributor Author

isha-73 commented Jun 6, 2023

Error alert has been updated!

Which issue is this?? Please create an issue to link to a pull request if it doesn't exists

It is issue 277

@isha-73
Copy link
Contributor Author

isha-73 commented Jun 6, 2023

Also, for this issue, I'd suggest you to go through the types of errors Firebase generates for those functions, so you can come to a concluding generic message easily.

Okay fine

@narayan954 narayan954 linked an issue Jun 6, 2023 that may be closed by this pull request
@narayan954
Copy link
Owner

narayan954 commented Jun 6, 2023

Error alert has been updated!

Which issue is this?? Please create an issue to link to a pull request if it doesn't exists

It is issue 277

Issue 277 is about client side validation :/, this is handling the server response. We can validate on the client side itself for email formatting(form validation in react)...

@isha-73
Copy link
Contributor Author

isha-73 commented Jun 6, 2023

Error alert has been updated!

Which issue is this?? Please create an issue to link to a pull request if it doesn't exists

It is issue 277

Issue 277 is about client side validation :/, this is handling the server response. We can validate on the client side itself for email formatting(form validation in react)...

Oh yes, u mean I should keep server response as it is and add client side validation

@isha-73
Copy link
Contributor Author

isha-73 commented Jun 6, 2023

@narayan954 can u check now, as u told I have updated alerts based on firebase errors.

@isha-73 isha-73 requested a review from narayan954 June 6, 2023 18:10
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit defa175 into narayan954:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Edit firebase alert on incorrect/correct login {GSSOC'23}
2 participants