-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue#277 Alert updated #441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)
Which issue is this?? Please create an issue to link to a pull request if it doesn't exists |
Also, for this issue, I'd suggest you to go through the types of errors Firebase generates for those functions, so you can come to a concluding generic message easily. |
It is issue 277 |
Okay fine |
Issue 277 is about client side validation :/, this is handling the server response. We can validate on the client side itself for email formatting(form validation in react)... |
Oh yes, u mean I should keep server response as it is and add client side validation |
@narayan954 can u check now, as u told I have updated alerts based on firebase errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Error alert has been updated!