Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added load more posts on scroll #52

Merged
merged 5 commits into from
Oct 3, 2022
Merged

Conversation

Pervolarakis
Copy link
Contributor

this should fix #30

src/App.jsx Outdated Show resolved Hide resolved
@narayan954
Copy link
Owner

Thanks a ton for contributing to the review @mathiasayivor . @Pervolarakis Can you please look into it ?
We crossed the daily limit of firebase because of lack of pagination (didn't expect that to happen) so this issue has to be solved on an urgent basis. Still we can wait for the quota to refresh(must be some hours , around PDT 00:00) so we can have a good look into it. Thanks for the contribution guys

@Pervolarakis
Copy link
Contributor Author

Pervolarakis commented Oct 2, 2022

added the suggested code but cant test it until the daily limit resets... I will push as soon as I have tested it

@mathiasayivor
Copy link
Contributor

Alright.

@mathiasayivor
Copy link
Contributor

The changes in this PR work as expected, but the scroll position resets when there is a new upload.

I have some other suggestions that would make the pagination solution complete (with support for post updates, etc), but would create a new issue since this PR is a priority now.

@narayan954
Copy link
Owner

Yeah , we'll look into it asap

@narayan954
Copy link
Owner

@Pervolarakis @mathiasayivor It works! , can you guys please recheck as well ?

@Pervolarakis
Copy link
Contributor Author

just checked it and seems to work fine

@narayan954
Copy link
Owner

yeah , just one doubt, I was checking the reads analytics in firebase and it still skyrockets the chart :( . It is possible that someone else is loading the old version .

@narayan954 narayan954 merged commit fb152c5 into narayan954:master Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FEATURE] Perf: Add pagination for posts
3 participants