Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique username for users #550

Merged
merged 5 commits into from
Jun 25, 2023
Merged

Conversation

Palakkgoyal
Copy link
Contributor

This PR closes issue no. #544
Approach

  • Created a new collection name username
  • Add the username as the doc id and the data of the document is the uid of user
  • Check if the username is valid or not. Username must only include letters, numbers and _
  • If valid username then, check if it already exist.
  • If not then let the user create a new id on dummygram using their username.

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 linked an issue Jun 25, 2023 that may be closed by this pull request
@narayan954 narayan954 merged commit 3fe7152 into narayan954:master Jun 25, 2023
@narayan954
Copy link
Owner

Thanks for your contribution! :)

@Palakkgoyal Palakkgoyal deleted the username branch June 27, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] Have a unique username
2 participants