-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added MUI alerts to replace browser alerts ⚠️ #57
Conversation
@warmachine028 Instead of creating a custom component, you might want to consider notistack, which has an imperative API and makes it easy to display snackbars, without having to handle their open/close state |
I have already closed 2 PRs regarding this issue. @narayan954 said that the notification was alright but it had issues in the merge conflicts. So I had to scrap out everything and begin from the start. Besides it was clearly mentioned in the issue #51 to use MUI alerts so I did it. Using notistack means I have to start again from scratch which seems quite cumbersome at this point |
I understand your pain, but notistack is actually quite easy to implement IMO. |
Sure you can try implementing in my fork |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be done using a dialogBox |
oh okayy |
Use MUI Alerts 📐
Changes Made
Used Material UI to add Snackbar Component
Added Snackbar to repalce browser alerts
Replaced all alerts and error messages and with Snackbar Notifications
Screenshots:
Logging In
Logging Out
Error Messages
Creating Post