Improved Post UI #643

Tisha6661 · 2023-07-04T07:48:26Z

The post Ui is made UI , More responsive , optimized css.

##Issue Number-
#628

Screenshots

better UI , More responsive , optimized CSS

Dark mode changes done

Tisha6661 · 2023-07-04T19:25:47Z

@narayan954 Is there any issue?

narayan954

Minor changes requested

can you please adjust the color of send button and No comments as well?

src/reusableComponents/ImageSlider/index.jsx

src/components/Post/index.css

narayan954 · 2023-07-04T19:39:55Z

@narayan954 Is there any issue?

its fine, just minor changes

narayan954 · 2023-07-04T21:21:17Z

Minor changes requested

can you please adjust the color of send button and No comments as well?

you may skip fixing the color of send button and No comments if you want. Someone else might work on that

Tisha6661 · 2023-07-05T05:59:42Z

No issues I have done that! Just fixing the height.

Changes done

Tisha6661 · 2023-07-05T06:58:16Z

I have changed the comment box, but now there is some issue with the site, I am unable to make changes @narayan954 -

narayan954 · 2023-07-05T08:31:03Z

No issues I have done that! Just fixing the height.

Hi @Tisha6661 , actually the daily free limit of firebase has been exceeded due to excess database calls, so currently the db is down.
It'll be available in some time when the quota resets.
We can use another db for testing the changes.
DM me for the test db credentials in discord.

EDIT: The app is back again and you can test

narayan954 · 2023-07-05T08:45:13Z

No issues I have done that! Just fixing the height.

I was reviewing this, height issue is yet to be fixed. Let me know when updated :)

narayan954

height issue left

Tisha6661 · 2023-07-05T15:53:43Z

@narayan954 I've checked several times, but the quota exceeded is showing everytime.

narayan954 · 2023-07-05T17:53:43Z

@narayan954 I've checked several times, but the quota exceeded is showing everytime.

oh ok then, contact me, I'll be generating some credentials for testing... you can/may also follow the steps in readme to generate your own credentials

narayan954 · 2023-07-05T17:58:52Z

https://github.com/narayan954/dummygram/blob/master/DATABASEconf.md

narayan954 · 2023-07-07T17:05:50Z

Hi @Tisha6661 are you working on this?

Tisha6661 · 2023-07-07T17:08:29Z

@narayan954 I tried working through firebase, but it was my first time, so i couldn't work on it. I was waiting for the site to work.

Tisha6661 · 2023-07-07T17:10:15Z

@narayan954 If it's working, I'll work right away.

narayan954 · 2023-07-09T18:11:56Z

src/components/Post/ImgBox.jsx

            <ReadMore postId={postId}>{caption}</ReadMore>
          </p>
        ) : (
          caption &&
          postHasImages && (
-            <p style={{ color: "var(--color)" }}>
+            <p style={{ color: "var(--color)", paddingInline: "16px" }}>
+              {caption}


caption is repeating, please fix that as well

Made changes in the card like image size and caption repeating issue.

into post-UI-improve

Tisha6661 · 2023-07-09T19:37:43Z

@narayan954 Made the changes, please review-

narayan954

Hi Tisha, responsiveness is breaking critically for mobile devices, can you please check that? rest everything seems fine.

Thank you.
I hope this is the last time I bug you on this issue XD

narayan954 · 2023-07-09T20:24:36Z

see :/

Tisha6661 · 2023-07-09T20:34:55Z

@narayan954 Long captions will again make the pages uneven, because in grid mode if we'll add long caption like this, which is uncertain in all posts, some will write small caption, and some no caption at all. So it would never would in grid view or make the cards even. See-

Unless we put an overflow auto.

narayan954 · 2023-07-10T20:48:52Z

@narayan954 Long captions will again make the pages uneven, because in grid mode if we'll add long caption like this, which is uncertain in all posts, some will write small caption, and some no caption at all. So it would never would in grid view or make the cards even. See-

Unless we put an overflow auto.

you're correct, I think either we can have a min height prop or the overflow control.... but there also please give it height enough to not look bad, as earlier it was just one line with scroll option. Sorry for delaying the pr

The cards are made responsive and the caption is made properly visible.

Tisha6661 · 2023-07-12T18:30:09Z

@narayan954 I have made the changes, here-

dummy.mp4

narayan954 · 2023-07-12T23:11:01Z

@narayan954 I have made the changes, here-

dummy.mp4

reviewing!

narayan954

looks good to me!

narayan954 · 2023-07-13T00:04:15Z

Thanks for your contribution!

* issue narayan954#628 resolved * better UI , More responsive , optimized CSS * Changes in card Dark mode changes done * moved post css to post * Comment box changes Changes done * Updated card Card height updated. * Updated the card Made changes in the card like image size and caption repeating issue. * removed extra lines and scrollbar for caption * Cards made responsive The cards are made responsive and the caption is made properly visible. * fix syntax error in profile.jsx --------- Co-authored-by: Narayan soni <narayansoni854@gmail.com>

Tisha6661 and others added 5 commits July 4, 2023 10:59

issue narayan954#628 resolved

b301b83

better UI , More responsive , optimized CSS

Changes in card

7cf541d

Dark mode changes done

Merge branch 'master' into post-UI-improve

7b3f9b9

format code

63f5388

Merge branch 'master' into pr/643

214e7ba

moved post css to post

391d23c

narayan954 requested changes Jul 4, 2023

View reviewed changes

src/reusableComponents/ImageSlider/index.jsx Show resolved Hide resolved

src/components/Post/index.css Show resolved Hide resolved

narayan954 added 2 commits July 5, 2023 01:39

Merge branch 'master' into post-UI-improve

d4362c2

Merge branch 'master' into post-UI-improve

7612f4c

Comment box changes

c6e75e2

Changes done

Tisha6661 requested a review from narayan954 July 5, 2023 06:58

narayan954 requested changes Jul 5, 2023

View reviewed changes

Merge branch 'master' into post-UI-improve

4ce8aca

narayan954 added 2 commits July 6, 2023 01:05

Merge branch 'master' into post-UI-improve

bf2c2ba

Merge branch 'master' into post-UI-improve

7ee25be

narayan954 added level1 codepeak labels Jul 7, 2023

narayan954 reviewed Jul 9, 2023

View reviewed changes

narayan954 and others added 3 commits July 10, 2023 00:09

Merge branch 'master' into post-UI-improve

e41e874

Updated the card

33d7a00

Made changes in the card like image size and caption repeating issue.

Merge branch 'post-UI-improve' of https://github.com/Tisha6661/dummygram

8133213

into post-UI-improve

Tisha6661 requested a review from narayan954 July 9, 2023 19:38

narayan954 added 2 commits July 10, 2023 01:37

format code

9439974

removed extra lines and scrollbar for caption

fcf108d

narayan954 requested changes Jul 9, 2023

View reviewed changes

Merge branch 'master' into post-UI-improve

1d0431a

narayan954 added level1 and removed level1 labels Jul 9, 2023

narayan954 linked an issue Jul 9, 2023 that may be closed by this pull request

Improve Posts Ui #628

Closed

narayan954 added level2 and removed level1 labels Jul 9, 2023

Cards made responsive

baf351e

The cards are made responsive and the caption is made properly visible.

Merge branch 'master' into post-UI-improve

68d9393

Tisha6661 requested a review from narayan954 July 12, 2023 18:32

Merge branch 'master' into post-UI-improve

64a9609

fix syntax error in profile.jsx

9cdc0af

narayan954 approved these changes Jul 13, 2023

View reviewed changes

narayan954 merged commit 205e8f8 into narayan954:master Jul 13, 2023
5 of 6 checks passed

narayan954 mentioned this pull request Jul 13, 2023

made home page ui responsive #765

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improved Post UI #643

Improved Post UI #643

Tisha6661 commented Jul 4, 2023 •

edited

Loading

Tisha6661 commented Jul 4, 2023

narayan954 left a comment

narayan954 commented Jul 4, 2023

narayan954 commented Jul 4, 2023

Tisha6661 commented Jul 5, 2023

Tisha6661 commented Jul 5, 2023 •

edited

Loading

narayan954 commented Jul 5, 2023 •

edited

Loading

narayan954 commented Jul 5, 2023 •

edited

Loading

narayan954 left a comment

Tisha6661 commented Jul 5, 2023

narayan954 commented Jul 5, 2023

narayan954 commented Jul 5, 2023

narayan954 commented Jul 7, 2023

Tisha6661 commented Jul 7, 2023

Tisha6661 commented Jul 7, 2023

narayan954 Jul 9, 2023

Tisha6661 commented Jul 9, 2023

narayan954 left a comment

narayan954 commented Jul 9, 2023

Tisha6661 commented Jul 9, 2023 •

edited

Loading

narayan954 commented Jul 10, 2023

Tisha6661 commented Jul 12, 2023

narayan954 commented Jul 12, 2023

narayan954 left a comment

narayan954 commented Jul 13, 2023

Improved Post UI #643

Improved Post UI #643

Conversation

Tisha6661 commented Jul 4, 2023 • edited Loading

Screenshots

Tisha6661 commented Jul 4, 2023

narayan954 left a comment

Choose a reason for hiding this comment

narayan954 commented Jul 4, 2023

narayan954 commented Jul 4, 2023

Tisha6661 commented Jul 5, 2023

Tisha6661 commented Jul 5, 2023 • edited Loading

narayan954 commented Jul 5, 2023 • edited Loading

narayan954 commented Jul 5, 2023 • edited Loading

narayan954 left a comment

Choose a reason for hiding this comment

Tisha6661 commented Jul 5, 2023

narayan954 commented Jul 5, 2023

narayan954 commented Jul 5, 2023

narayan954 commented Jul 7, 2023

Tisha6661 commented Jul 7, 2023

Tisha6661 commented Jul 7, 2023

narayan954 Jul 9, 2023

Choose a reason for hiding this comment

Tisha6661 commented Jul 9, 2023

narayan954 left a comment

Choose a reason for hiding this comment

narayan954 commented Jul 9, 2023

Tisha6661 commented Jul 9, 2023 • edited Loading

narayan954 commented Jul 10, 2023

Tisha6661 commented Jul 12, 2023

narayan954 commented Jul 12, 2023

narayan954 left a comment

Choose a reason for hiding this comment

narayan954 commented Jul 13, 2023

Tisha6661 commented Jul 4, 2023 •

edited

Loading

Tisha6661 commented Jul 5, 2023 •

edited

Loading

narayan954 commented Jul 5, 2023 •

edited

Loading

narayan954 commented Jul 5, 2023 •

edited

Loading

Tisha6661 commented Jul 9, 2023 •

edited

Loading