-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made home page ui responsive #765
Conversation
Hey @narayan954 , I have checked while inspecting and it was working fine. Could you please elaborate a bit as what is the issue? |
Hello, actually some style properties were changed in pr #643 and in between padding property got overridden at some places I suppose. That might be the issue. |
On it |
right, thanks for fixing! |
reviewing, and upgraded issue to level 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @anamika7153 little changes requested.
In row mode there's whitespace in the sidebar as you can see in the screenshot
Also reduce the bottom margin please
we may fix the scroll to top button later...
|
noted |
bottom margin??? talking about bottom margin of post? |
yes, for the last post |
@narayan954 Have a look :) |
gotcha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me! :)
Thanks for fixing this! :) I'm really bad with css ;-; |
You're welcome :) You'll get there. Even I'm not too good. |
Close: #630
Video (BEFORE)
dummygram_home-ui_responsive.Original.mp4
Video (AFTER)
dummygram_home_ui_responsive.Original.mp4