Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made home page ui responsive #765

Merged
merged 18 commits into from
Jul 14, 2023
Merged

Conversation

anamika7153
Copy link
Contributor

Close: #630

  • Home page UI was not responsive below 800px and below 1200px.

Video (BEFORE)

dummygram_home-ui_responsive.Original.mp4

Video (AFTER)

dummygram_home_ui_responsive.Original.mp4

@narayan954
Copy link
Owner

It was fine until I merged the master branch in it :(, the mobile screens are not working well unfortunately. Also this affects profile page as well because both have same css for posts.
image

Can you please try fixing that?

@anamika7153
Copy link
Contributor Author

anamika7153 commented Jul 13, 2023

It was fine until I merged the master branch in it :(, the mobile screens are not working well unfortunately. Also this affects profile page as well because both have same css for posts.

Can you please try fixing that?

Hey @narayan954 , I have checked while inspecting and it was working fine. Could you please elaborate a bit as what is the issue?

@narayan954
Copy link
Owner

narayan954 commented Jul 13, 2023

It was fine until I merged the master branch in it :(, the mobile screens are not working well unfortunately. Also this affects profile page as well because both have same css for posts.
Can you please try fixing that?

It was fine until I merged the master branch in it :(, the mobile screens are not working well unfortunately. Also this affects profile page as well because both have same css for posts.
Can you please try fixing that?

Hey @narayan954 , I have checked while inspecting and it was working fine. Could you please elaborate a bit as what is the issue?

Hello, actually some style properties were changed in pr #643 and in between padding property got overridden at some places I suppose. That might be the issue.

@anamika7153
Copy link
Contributor Author

It was fine until I merged the master branch in it :(, the mobile screens are not working well unfortunately. Also this affects profile page as well because both have same css for posts.
Can you please try fixing that?

It was fine until I merged the master branch in it :(, the mobile screens are not working well unfortunately. Also this affects profile page as well because both have same css for posts.
Can you please try fixing that?

Hey @narayan954 , I have checked while inspecting and it was working fine. Could you please elaborate a bit as what is the issue?

Hello, actually some style properties were changed in pr #643 and in between padding property got overridden at some places I suppose. That might be the issue.

On it

@anamika7153 anamika7153 marked this pull request as draft July 13, 2023 14:34
@anamika7153 anamika7153 marked this pull request as ready for review July 13, 2023 14:57
@anamika7153
Copy link
Contributor Author

@narayan954

  • Also the posts cards were not centrally aligned before.
Before Updated
image image
image image
image image
image image

@narayan954
Copy link
Owner

@narayan954

  • Also the posts cards were not centrally aligned before.

Before Updated
image image
image image
image image
image image

@narayan954

  • Also the posts cards were not centrally aligned before.

Before Updated
image image
image image
image image
image image

right, thanks for fixing!

@narayan954
Copy link
Owner

reviewing, and upgraded issue to level 2

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @anamika7153 little changes requested.
In row mode there's whitespace in the sidebar as you can see in the screenshot
image
Also reduce the bottom margin please
image
we may fix the scroll to top button later...

@narayan954
Copy link
Owner

Hi @anamika7153 little changes requested. In row mode there's whitespace in the sidebar as you can see in the screenshot !Also reduce the bottom margin please

Also slightly reduce the top margin
image

@anamika7153
Copy link
Contributor Author

Hi @anamika7153 little changes requested. In row mode there's whitespace in the sidebar as you can see in the screenshot !Also reduce the bottom margin please

Also slightly reduce the top margin image

noted

@anamika7153
Copy link
Contributor Author

Hi @anamika7153 little changes requested. In row mode there's whitespace in the sidebar as you can see in the screenshot image Also reduce the bottom margin please image we may fix the scroll to top button later...

bottom margin??? talking about bottom margin of post?

@narayan954
Copy link
Owner

Hi @anamika7153 little changes requested. In row mode there's whitespace in the sidebar as you can see in the screenshot image Also reduce the bottom margin please image we may fix the scroll to top button later...

bottom margin??? talking about bottom margin of post?

yes, for the last post

@anamika7153
Copy link
Contributor Author

@narayan954 Have a look :)

@narayan954
Copy link
Owner

@narayan954 Have a look :)

gotcha

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! :)

@narayan954 narayan954 merged commit 4139d73 into narayan954:master Jul 14, 2023
5 of 6 checks passed
@narayan954
Copy link
Owner

narayan954 commented Jul 14, 2023

Thanks for fixing this! :) I'm really bad with css ;-;

@anamika7153
Copy link
Contributor Author

Thanks for fixing this! :) I'm really bad with css ;-;

You're welcome :) You'll get there. Even I'm not too good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[BUG]: Home page UI not responsive
2 participants