Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added search bar in home #838

Merged
merged 17 commits into from
Jul 20, 2023
Merged

Conversation

krutikajichkar
Copy link
Contributor

fixed #826

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Krutika, position of search bar is not good inside the post's container as it's treated as a post and hence in column/row mode it's not visible correctly. Please correct that and check the comments I've added.
image

src/App.jsx Outdated Show resolved Hide resolved
src/App.jsx Outdated Show resolved Hide resolved
@krutikajichkar
Copy link
Contributor Author

@narayan954 This was not the UI that I encountered while making the search bar

@narayan954
Copy link
Owner

narayan954 commented Jul 18, 2023

@narayan954 This was not the UI that I encountered while making the search bar

there's a button on the top right side, it's to switch to column mode, you didn't see that I understand, but in the codebase search bar div should not be contained in post's container. It should be separate/before the post container.

Separating it should work

@krutikajichkar
Copy link
Contributor Author

@narayan954 This was not the UI that I encountered while making the search bar

there's a button on the top right side, it's to switch to column mode, you didn't see that I understand, but in the codebase search bar div should not be contained in post's container. It should be separate/before the post container.

Separating it should work

Okay got it

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @krutikajichkar , please position it correctly.
image

@krutikajichkar
Copy link
Contributor Author

krutikajichkar commented Jul 18, 2023

Screenshot (180)
@narayan954 reveiw this

@narayan954
Copy link
Owner

Screenshot (180) @narayan954 reveiw this

but it's not even at center :/

@krutikajichkar
Copy link
Contributor Author

krutikajichkar commented Jul 19, 2023

DummyGram.mp4

@narayan954 i have created 13 to 14 posts of name krutika jichkar , you can now search it will show you all 13 to 14 posts which means after pagesize of 10 posts it will load more posts . Please review this and also check for alignment of search bar .

Loading of posts might take time.

@krutikajichkar
Copy link
Contributor Author

@narayan954 There may be problem with the search bar alignment , I tried to justify it to the center but then it was not in center with posts , i tried adding some divs and this is what i ended up to , please look into this if you can solve that

@narayan954
Copy link
Owner

narayan954 commented Jul 19, 2023

@narayan954 There may be problem with the search bar alignment , I tried to justify it to the center but then it was not in center with posts , i tried adding some divs and this is what i ended up to , please look into this if you can solve that

alright! I'll merge this tomorrow if that's okay

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@narayan954 narayan954 merged commit a71403b into narayan954:master Jul 20, 2023
4 of 5 checks passed
@krutikajichkar
Copy link
Contributor Author

@narayan954 Isn't there any label for this?

narayan954 added a commit that referenced this pull request Jul 20, 2023
@krutikajichkar
Copy link
Contributor Author

@narayan954 Isn't there any label for this?

@narayan954

narayan954 added a commit to Palakkgoyal/dummygram that referenced this pull request Jul 20, 2023
@narayan954
Copy link
Owner

@narayan954 Isn't there any label for this?

@narayan954

ooops sorry I forgot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[OTHER] Search Bar Alignment
2 participants