-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added search bar in home #838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@narayan954 This was not the UI that I encountered while making the search bar |
there's a button on the top right side, it's to switch to column mode, you didn't see that I understand, but in the codebase search bar div should not be contained in post's container. It should be separate/before the post container. Separating it should work |
Okay got it |
7750466
to
5247589
Compare
5247589
to
82a7ccc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @krutikajichkar , please position it correctly.
|
but it's not even at center :/ |
DummyGram.mp4@narayan954 i have created 13 to 14 posts of name krutika jichkar , you can now search it will show you all 13 to 14 posts which means after pagesize of 10 posts it will load more posts . Please review this and also check for alignment of search bar . Loading of posts might take time. |
@narayan954 There may be problem with the search bar alignment , I tried to justify it to the center but then it was not in center with posts , i tried adding some divs and this is what i ended up to , please look into this if you can solve that |
alright! I'll merge this tomorrow if that's okay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@narayan954 Isn't there any label for this? |
This reverts commit a71403b.
|
ooops sorry I forgot. |
fixed #826