Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a community chat page for dummygram #879

Merged
merged 7 commits into from
Jul 20, 2023

Conversation

Palakkgoyal
Copy link
Contributor

This PR closes issue no. #842
I have created a community chat room with a nice and simple UI and it is also enough responsive that will give the feel of real chat. I have also set up routes such that whenever someone click on the image of the person who sent the message then they will be routed to that user profile.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@narayan954 narayan954 linked an issue Jul 20, 2023 that may be closed by this pull request
4 tasks
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Palakkgoyal this looks great! but there're some issues, sidebar is being affected by these chats,it's going down,bad
prrrr
Along with issues mentioned in pic, New chats are not showing up now as well.
Can you please take a look and try to fix them?

@narayan954
Copy link
Owner

Hi @Palakkgoyal this looks great! but there're some issues, sidebar is being affected by these chats,it's going down,bad prrrr Along with issues mentioned in pic, New chats are not showing up now as well. Can you please take a look and try to fix them?

image

@Palakkgoyal
Copy link
Contributor Author

Palakkgoyal commented Jul 20, 2023

Hey @narayan954 I can fix other issues but this navbar issue is not because of me cause I checked today Navbar

Hi @Palakkgoyal this looks great! but there're some issues, sidebar is being affected by these chats,it's going down,bad prrrr Along with issues mentioned in pic, New chats are not showing up now as well. Can you please take a look and try to fix them?

Hey @narayan954 its not going down. It must be affected by other commit. As you could see my branch has no new commits so the sidebar is not going down but you are trying in updated branch and the problem is happening.
But Okay I will try to fix it.
Screenshot (616)

@Palakkgoyal
Copy link
Contributor Author

Ok I will fix all issues.

@narayan954
Copy link
Owner

narayan954 commented Jul 20, 2023

Hey @narayan954 I can fix other issues but this navbar issue is not because of me cause I checked today Navbar

Hi @Palakkgoyal this looks great! but there're some issues, sidebar is being affected by these chats,it's going down,bad ! Along with issues mentioned in pic, New chats are not showing up now as well. Can you please take a look and try to fix them?

Hey @narayan954 its not going down. It must be affected by other commit. As you could see my branch has no new commits so the sidebar is not going down but you are trying in updated branch and the problem is happening. But Okay I will try to fix it.

Ohhh that's the case, I'm sorry. I think in one of the commit, logic is different and hence causing this conflict, could be number #838 . I'll also try finding the cause.
Also, you can remove that windows watermark in yo desktop by activating it using this less than 2 minutes tutorial (also it's safe, permanent(almost) and open source)

@narayan954
Copy link
Owner

Hi I've fixed most of the stuffs by reverting the commit, now there's just little bugs I guess.
image
icon alignment, and new messages are not showing up now. Also, for these chats, we can later add pagination

@Palakkgoyal
Copy link
Contributor Author

Thanks a lot for fixing. You saved my time. The new one are not showing up might be due to I have set up limit of 20 docs and they are getting fetched based on timestamp from old to new and not from new to old.

@Palakkgoyal
Copy link
Contributor Author

Palakkgoyal commented Jul 20, 2023

Hey @narayan954 I did the required changes. Can you please check.
And your solution worked. Thanks for sharing. I was so habitual of that mark that it felt like the part of my laptop😂. Now the space is looking clean :)
Screenshot (618)

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954
Copy link
Owner

Hey @narayan954 I did the required changes. Can you please check. And your solution worked. Thanks for sharing. I was so habitual of that mark that it felt like the part of my laptopjoy. Now the space is looking clean :) Screenshot (618)

Sure, it looks great!,Thank you!

@narayan954 narayan954 merged commit 4b65813 into narayan954:master Jul 20, 2023
3 of 4 checks passed
@Palakkgoyal Palakkgoyal deleted the communityChatRoom branch July 24, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] A chatroom for all
2 participants