-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a community chat page for dummygram #879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Palakkgoyal! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Palakkgoyal this looks great! but there're some issues, sidebar is being affected by these chats,it's going down,bad
Along with issues mentioned in pic, New chats are not showing up now as well.
Can you please take a look and try to fix them?
|
Hey @narayan954 I can fix other issues but this navbar issue is not because of me cause I checked today Navbar
Hey @narayan954 its not going down. It must be affected by other commit. As you could see my branch has no new commits so the sidebar is not going down but you are trying in updated branch and the problem is happening. |
Ok I will fix all issues. |
Ohhh that's the case, I'm sorry. I think in one of the commit, logic is different and hence causing this conflict, could be number #838 . I'll also try finding the cause. |
497d34b
to
2800107
Compare
Thanks a lot for fixing. You saved my time. The new one are not showing up might be due to I have set up limit of 20 docs and they are getting fetched based on timestamp from old to new and not from new to old. |
Hey @narayan954 I did the required changes. Can you please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
Sure, it looks great!,Thank you! |
This PR closes issue no. #842
I have created a community chat room with a nice and simple UI and it is also enough responsive that will give the feel of real chat. I have also set up routes such that whenever someone click on the image of the person who sent the message then they will be routed to that user profile.