bug fix for the profile page view Profile bug fix for issue #912 #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
narayan954
requested changes
Jul 24, 2023
| @@ -189,6 +189,8 @@ function Post(prop) { | |||
| }} | |||
| > | |||
| <ErrorBoundary> | |||
| { | |||
| !profile && | |||
There was a problem hiding this comment.
we don't need to hide the header completely, we just had to hide the visit profile option, as you had mentioned there as well. Also, instead of prop drilling, you can instead check the current route as well, uselocation... or there might be other better ways as well
This was
linked to
issues
Jul 24, 2023
4 tasks
|
why duplicate pr? closing |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on profile page we need to hide the three dot bug fix for #912
Before :-
After:-
