Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for issue number #912 #957

Merged
merged 6 commits into from
Jul 26, 2023

Conversation

biplavmz
Copy link
Contributor

bug issue solve for bug number #912

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you biplavmz! for creating this pull request and contributing to Dummygram! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

src/components/Post/PostHeader.jsx Outdated Show resolved Hide resolved
@narayan954
Copy link
Owner

narayan954 commented Jul 25, 2023

Also you created separate pr instead of fixing that pr(#928), dont do that, I won't be checking every new pr for the same issue, and close older one. Don't create duplicates. You can just add commit to the pr and it'd get reflected here.
If you create another duplicate pr for this same issue instead of working on this only, I'll void this submission and not allow you to contribute in this repository. You've been doing this for quite some time now.

@narayan954 narayan954 linked an issue Jul 25, 2023 that may be closed by this pull request
4 tasks
@biplavmz
Copy link
Contributor Author

ok @narayan954

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit d98b63f into narayan954:master Jul 26, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

hide the three dot button in the profile page
2 participants