ZOOKEEPER-3708: Move Logging Code into Logging Guard in Learner

Author: David Mollitor <dmollitor@apache.org> Reviewers: eolivelli@apache.org, andor@apache.org Closes apache#1240 from belugabehr/ZOOKEEPER-3708
narendly · Feb 3, 2020 · 68e1f7d · 68e1f7d
1 parent d3ce1fa
commit 68e1f7d
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java b/zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/Learner.java
@@ -217,11 +217,11 @@ void readPacket(QuorumPacket pp) throws IOException {
             leaderIs.readRecord(pp, "packet");
             messageTracker.trackReceived(pp.getType());
         }
-        long traceMask = ZooTrace.SERVER_PACKET_TRACE_MASK;
-        if (pp.getType() == Leader.PING) {
-            traceMask = ZooTrace.SERVER_PING_TRACE_MASK;
-        }
         if (LOG.isTraceEnabled()) {
+            final long traceMask =
+                (pp.getType() == Leader.PING) ? ZooTrace.SERVER_PING_TRACE_MASK
+                    : ZooTrace.SERVER_PACKET_TRACE_MASK;
+
             ZooTrace.logQuorumPacket(LOG, traceMask, 'i', pp);
         }
     }