feat(Toggle): Adds a loading and disabled state for the Toggle component #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JohnathanWeisner
commented
May 7, 2024
JohnathanWeisner
commented
…oggle--loading-and-disabled-states
akdetrick
reviewed
May 7, 2024
src/LoadingShim/index.js
Outdated
| @@ -36,6 +49,8 @@ LoadingShim.propTypes = { | |||
| isLoading: PropTypes.bool, | |||
| /** Optional value for `data-testid` attribute */ | |||
| testId: PropTypes.string, | |||
| /** Size of the loading indicator */ | |||
| size: PropTypes.oneOf(["small", "large"]), | |||
There was a problem hiding this comment.
for consistency with other size names:
Suggested change
| size: PropTypes.oneOf(["small", "large"]), | |
| size: PropTypes.oneOf(["s", "l"]), |
src/LoadingShim/index.js
Outdated
| isLoading = false, | ||
| children, | ||
| testId, | ||
| size = "large", |
There was a problem hiding this comment.
Suggested change
| size = "large", | |
| size = "l", |
src/Toggle/index.js
Outdated
| > | ||
| <span className="nds-toggle-indicator elevation--low" /> | ||
| <div className="nds-toggle-loading-overlay"> | ||
| <LoadingShim size="small" isLoading /> |
There was a problem hiding this comment.
Suggested change
| <LoadingShim size="small" isLoading /> | |
| <LoadingShim size="s" isLoading /> |
src/LoadingShim/index.js
Outdated
| className={cc([ | ||
| "nds-loadingShim", | ||
| { | ||
| "nds-loadingShim--small": size === "small", |
There was a problem hiding this comment.
Suggested change
| "nds-loadingShim--small": size === "small", | |
| "nds-loadingShim--small": size === "s", |
📘 Storybook Preview Available 👀View the Storybook build from this PR in your browser: (This action will publish a new comment and url if this PR is modified) |
akdetrick
approved these changes
May 8, 2024
|
🎉 This PR is included in version 3.36.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.