fix(TextInput): set label text to xs to avoid resizing container on focus #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📘 Storybook Preview Available 👀View the Storybook build from this PR in your browser: (This action will publish a new comment and url if this PR is modified) |
akdetrick
approved these changes
Jun 27, 2024
|
🎉 This PR is included in version 3.41.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one had me stumped for a minute but it ended up being something pretty obvious - when the
TextInputwas focused, you could see the container get taller which resulted in the page content shifting downward, not desirable behavior.I figured out that it was caused by this commit because reverting it fixed the issue, but I was sure it must be something to do with the negative margins on the
labelthat had been changed to use theremfunction. Turns out, we were just setting thelabelfont to be too big. After I made this change, I can confirm in my browser that--font-size-xsis0.75remwhich calculates under default settings to12px, which is what it used to be before that commit.--font-size-smade it14pxwhich resulted in the resizing on focus.