fix(MenuButton): prevent react-aria scrolljacking #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphicsforge
approved these changes
Jul 30, 2024
📘 Storybook Preview Available 👀View the Storybook build from this PR in your browser: (This action will publish a new comment and url if this PR is modified) |
|
🎉 This PR is included in version 3.45.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes NDS-390
react-laaguseLayerhook for popover instead of thereact-ariaPopover. This avoids problematic behaviors fromreact-aria, like scrolling top and locking body scroll.closePopoverso that theonActionof the Menu component is called before the popover closesTested against
bankingin3.46.0-beta.{patch}releases.