-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RadioButtons): add RadioButtons #294
Conversation
77a8a1e
to
b9f258f
Compare
@@ -0,0 +1,42 @@ | |||
import React, { useState } from "react"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏 thank you for adding a story
Green: "green", | ||
Yellow: "yellow", | ||
}} | ||
name="colours" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇬🇧
This is a little ambiguous - you're right that this would normally be a breaking change, but I would recommend instead you reword your commit as a We have a lot of dead components in our tree right now... The To deal with this weird state of NDS, I am considering components "Available" only if they meet one or both of these conditions:
tl;dr I consider this change a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - before merging, can we reword the commit as something like feat(RadioButtons): Add RadioButtons
instead of fix...
?
b9f258f
to
9f038bb
Compare
## [1.6.0](v1.5.0...v1.6.0) (2021-10-28) ### Features * **RadioButtons:** add RadioButtons ([#294](#294)) ([9e77354](9e77354))
🎉 This PR is included in version 1.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
close #293
The important change is removing that
onEffect
, since we want the options to be dynamic, so if the user performs an action elsewhere on the page or an asyc event completes that changes the options, we reflect that change.Maybe this is a breaking change though? cc @akdetrick