Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bucket Sort #49

Merged
merged 2 commits into from
Oct 7, 2019
Merged

feat: Bucket Sort #49

merged 2 commits into from
Oct 7, 2019

Conversation

gautam678
Copy link
Contributor

@gautam678 gautam678 commented Oct 7, 2019

Bucket sort relies internally on insertion sort, which is why there is another commit for insertion sort. I don't think this will cause merge conflict.

@gautam678 gautam678 mentioned this pull request Oct 7, 2019
@codecov-io
Copy link

Codecov Report

Merging #49 into master will increase coverage by 1.13%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   89.53%   90.67%   +1.13%     
==========================================
  Files          13       14       +1     
  Lines         172      193      +21     
  Branches       19       22       +3     
==========================================
+ Hits          154      175      +21     
  Misses         17       17              
  Partials        1        1
Impacted Files Coverage Δ
src/algorithms/sorting/insertionSort.js 100% <100%> (ø) ⬆️
src/algorithms/sorting/bucketSort.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177cff6...38d1db7. Read the comment docs.

@nas5w nas5w merged commit b7b2472 into nas5w:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants