Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure build directory layout #652

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

lpsinger
Copy link
Member

@lpsinger lpsinger commented Mar 3, 2023

With two Lambdas and another maybe coming soon, the build directory layout was getting messy and distracting. Unify most generated files into a single top-level /build directory.

  • The Remix server-side bundle goes into /build/server.
  • The Remix client-side build goes into /build/static.
  • Lambdas that handle SNS events go into /build/events.
  • Intermediate Gulp build output goes into /build/theme.

Also, the source for the email-incoming Lambda goes into /app/events/email-incoming.

With two Lambdas and another maybe coming soon, the build directory
layout was getting messy and distracting. Unify most generated
files into a single top-level /build directory.

- The Remix server-side bundle goes into /build/server.
- The Remix client-side build goes into /build/static.
- Lambdas that handle SNS events go into /build/events.
- Intermediate Gulp build output goes into /build/theme.

Also, the source for the email-incoming Lambda goes into
/app/events/email-incoming.
@lpsinger lpsinger added the infrastructure Issue relates to infrastructure (DevOps, cloud resources, etc.) label Mar 3, 2023
@lpsinger lpsinger requested a review from dakota002 March 3, 2023 00:59
@dakota002 dakota002 merged commit 23c5e8e into nasa-gcn:main Mar 3, 2023
@lpsinger lpsinger deleted the build-directory branch March 3, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issue relates to infrastructure (DevOps, cloud resources, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants