Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix float point overflow bug #15

Closed
wants to merge 1 commit into from
Closed

fix float point overflow bug #15

wants to merge 1 commit into from

Conversation

vliqi
Copy link
Contributor

@vliqi vliqi commented Apr 10, 2018

beacause of float point overflow, run SST turbulence model on
single precision version cfl3d program may cause crash problem.
such as On ONERA M6 WING Test Case (https://cfl3d.larc.nasa.gov/Cfl3dv6/cfl3dv6_testcases.html#onera),
if change ivisc=5 to 7, even set edvislim keyword to 100000, the program will cause crash error:

`Program received signal SIGFPE: Floating-point exception - erroneous arithmetic operation.

Backtrace for this error:
#0 0x7f4503de6d4a
#1 0x7f4503de5f7d
#2 0x7f450330502f
#3 0x563ac206f6e4
#4 0x563ac2322f71
#5 0x563ac21f987d
#6 0x563ac23a5a5d
#7 0x563ac23b45f8
#8 0x563ac24077b4
#9 0x563ac2054048
#10 0x7f45032f22b0
#11 0x563ac2054079
#12 0xffffffffffffffff`

beacause of float point overflow, run SST turbulence model on
single precision version cfl3d program may cause crash problem.
@crumsey
Copy link
Collaborator

crumsey commented Jun 25, 2018

We have to be careful with this kind of fix. It is changing the model, albeit apparently only in a minor way. But it is a change. Old results will no longer be duplicated.

@vliqi vliqi closed this Aug 29, 2018
@vliqi vliqi deleted the fix_float_overflow branch September 8, 2018 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants