-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A CMake build system for cfl3d and some bug fixes (at least in Linux) #4
base: master
Are you sure you want to change the base?
Conversation
…x to be compared with other numbers when compiling complex version of cfl3d
…tran under Ubuntu 16.04
very good job.I will test Intel fortran&Absoft fortran in windows |
@vliqi However, because the $ grep -i warning make.log
cc1: warning: command line option ‘-Wno-align-commons’ is valid for Fortran but not for C
cc1: warning: command line option ‘-fdefault-real-8’ is valid for Fortran but not for C
cc1: warning: command line option ‘-fbacktrace’ is valid for Fortran but not for C
Warning: Named COMMON block ‘info’ at (1) shall be of the same size as elsewhere (192 vs 392 bytes)
Warning: Named COMMON block ‘reyue’ at (1) shall be of the same size as elsewhere (32 vs 16 bytes)
Warning: Named COMMON block ‘info’ at (1) shall be of the same size as elsewhere (192 vs 392 bytes)
Warning: Named COMMON block ‘reyue’ at (1) shall be of the same size as elsewhere (16 vs 32 bytes)
Warning: Named COMMON block ‘info’ at (1) shall be of the same size as elsewhere (192 vs 392 bytes)
Warning: Named COMMON block ‘reyue’ at (1) shall be of the same size as elsewhere (16 vs 32 bytes)
Warning: Named COMMON block ‘info’ at (1) shall be of the same size as elsewhere (192 vs 392 bytes)
Warning: Named COMMON block ‘reyue’ at (1) shall be of the same size as elsewhere (16 vs 32 bytes)
Warning: Named COMMON block ‘info’ at (1) shall be of the same size as elsewhere (192 vs 392 bytes)
Warning: Named COMMON block ‘info’ at (1) shall be of the same size as elsewhere (224 vs 392 bytes)
Warning: Named COMMON block ‘info’ at (1) shall be of the same size as elsewhere (192 vs 392 bytes)
Warning: Named COMMON block ‘info’ at (1) shall be of the same size as elsewhere (224 vs 392 bytes)
Warning: Named COMMON block ‘info’ at (1) shall be of the same size as elsewhere (224 vs 392 bytes)
Warning: Named COMMON block ‘turbconv’ at (1) shall be of the same size as elsewhere (128 vs 64 bytes)
Warning: Named COMMON block ‘turbconv’ at (1) shall be of the same size as elsewhere (56 vs 128 bytes)
Warning: Named COMMON block ‘info’ at (1) shall be of the same size as elsewhere (224 vs 392 bytes)
Warning: Named COMMON block ‘reyue’ at (1) shall be of the same size as elsewhere (16 vs 32 bytes)
Warning: Named COMMON block ‘info’ at (1) shall be of the same size as elsewhere (192 vs 392 bytes)
Warning: Named COMMON block ‘reyue’ at (1) shall be of the same size as elsewhere (16 vs 32 bytes)
Warning: Named COMMON block ‘info’ at (1) shall be of the same size as elsewhere (192 vs 392 bytes)
Warning: Named COMMON block ‘reyue’ at (1) shall be of the same size as elsewhere (16 vs 32 bytes)
Warning: Named COMMON block ‘info’ at (1) shall be of the same size as elsewhere (192 vs 392 bytes)
Warning: Named COMMON block ‘reyue’ at (1) shall be of the same size as elsewhere (16 vs 32 bytes)
Warning: Named COMMON block ‘info’ at (1) shall be of the same size as elsewhere (192 vs 392 bytes)
Warning: Named COMMON block ‘reyue’ at (1) shall be of the same size as elsewhere (16 vs 32 bytes)
Warning: Named COMMON block ‘info’ at (1) shall be of the same size as elsewhere (192 vs 392 bytes)
Warning: Named COMMON block ‘reyue’ at (1) shall be of the same size as elsewhere (16 vs 32 bytes)
Warning: Named COMMON block ‘info’ at (1) shall be of the same size as elsewhere (224 vs 392 bytes)
Warning: Named COMMON block ‘reyue’ at (1) shall be of the same size as elsewhere (16 vs 32 bytes)
Warning: Named COMMON block ‘deformz’ at (1) shall be of the same size as elsewhere (48 vs 56 bytes)
Warning: Named COMMON block ‘deformz’ at (1) shall be of the same size as elsewhere (48 vs 56 bytes)
Warning: Named COMMON block ‘deformz’ at (1) shall be of the same size as elsewhere (88 vs 56 bytes)
Warning: Named COMMON block ‘unst’ at (1) shall be of the same size as elsewhere (80 vs 48 bytes)
Warning: Legacy Extension: Label at (1) is not in the same block as the GOTO statement at (2)
Warning: Legacy Extension: Label at (1) is not in the same block as the GOTO statement at (2)
Warning: Legacy Extension: Label at (1) is not in the same block as the GOTO statement at (2)
Warning: Type mismatch in argument ‘x’ at (1); passed COMPLEX(8) to REAL(8)
Warning: Type mismatch in argument ‘x’ at (1); passed COMPLEX(8) to REAL(8)
Warning: Type mismatch in argument ‘x’ at (1); passed COMPLEX(8) to REAL(8)
Warning: Type mismatch in argument ‘x’ at (1); passed COMPLEX(8) to REAL(8)
Warning: Legacy Extension: Label at (1) is not in the same block as the GOTO statement at (2)
Warning: Legacy Extension: Label at (1) is not in the same block as the GOTO statement at (2)
Warning: Legacy Extension: Label at (1) is not in the same block as the GOTO statement at (2) There are four types of them:
I think refractoring of the old fortran code is needed. |
Hi, Christopher Rumsey
Thanks for your cfl3d code going public. I used this code and I thought it was very difficult to build it. So I wrote a cmake build system to detect MPI/CGNS libs, configure cfl3d automatically and generate makefile or IDE projects for compilation automatically. I think it may be helpful to someone.
The modification of CMake branch is limited to:
bc2010.F, barth3d.F, foureqn.F, global.F spalart.F
are enclosed byreal()
function to avoid errors during compilation of complex version of cfl3d.cputime.F
of maggie, a gfortran version of intrisic functionETIME
is added to conditional compilation to improve compatability of cfl3d to gfortran in Linux.CFL3D/testcase
directory.I have tested it in a linux OS - Ubuntu 16.04 LTS.
FYI, cmake of kitware.inc is a cross platform build system widely used in industry. Here is a trend of serveral automatic build tools.
![comparison of serveral automatic build tools](https://camo.githubusercontent.com/57da699e01da1a63acc254a049b0cfc92d7909caafd003cc4c99991fa6376cd8/68747470733a2f2f696d6167652e736c696465736861726563646e2e636f6d2f636d616b652d3135303532323130323533312d6c7661312d617070363839312f39352f636d616b652d696e74726f64756374696f6e2d616e642d626573742d7072616374696365732d322d3633382e6a70673f63623d31343332323935333739)
Best regards.
Di Cheng Ph.D.
Engineer in fluid mechanics
Research and Development Center
China Academy of Aerospace Aerodynamics
Phone: +86-l58Ol5949ll
Address: No.17, YunGang West Road, Fengtai District, Beijing, China
Zip Code:100074