Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

169 aos support #207

Merged
merged 33 commits into from
Dec 13, 2023
Merged

169 aos support #207

merged 33 commits into from
Dec 13, 2023

Conversation

dccutrig
Copy link
Contributor

Core AOS Encryption/Decryption Capabilities with working UTs

…aged_parameter, add UT testing fhec presence
@dccutrig dccutrig added the enhancement New feature or request label Dec 12, 2023
@dccutrig dccutrig self-assigned this Dec 12, 2023
@rjbrown2
Copy link
Contributor

Looks good. Unit tests done nicely. We will probably need to refactor the apply/process functions here as we will everywhere else also.

@codecov-commenter
Copy link

Codecov Report

Attention: 133 lines in your changes are missing coverage. Please review.

Comparison is base (8ea632e) 84.92% compared to head (4ab40cd) 85.30%.

Files Patch % Lines
src/core/crypto_aos.c 74.68% 121 Missing ⚠️
test/unit/ut_sadb_err_cases_kmc_crypto.c 0.00% 4 Missing ⚠️
src/sa/internal/sa_interface_inmemory.template.c 94.64% 3 Missing ⚠️
test/unit/ut_mysql_m_tls_connection.c 0.00% 2 Missing ⚠️
test/unit/ut_mysql_tls_connection.c 0.00% 2 Missing ⚠️
src/core/crypto_print.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #207      +/-   ##
==========================================
+ Coverage   84.92%   85.30%   +0.38%     
==========================================
  Files          33       34       +1     
  Lines        7913     8943    +1030     
==========================================
+ Hits         6720     7629     +909     
- Misses       1193     1314     +121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlucas9 jlucas9 merged commit 848515f into dev Dec 13, 2023
4 checks passed
@jlucas9 jlucas9 deleted the 169-aos-support branch December 13, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants