Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI additions, and minor fixes #24

Merged
merged 4 commits into from
Dec 7, 2021
Merged

CI additions, and minor fixes #24

merged 4 commits into from
Dec 7, 2021

Conversation

rjbrown2
Copy link
Contributor

@rjbrown2 rjbrown2 commented Dec 7, 2021

Moved to this pull request from the one that was closed out previously.

This will allow for a clean merge into the collab_main base.

This contains CI additions, a fix for a unit test that was printing data that wasn't needed, and a minor fix in a header file that had a hardcoded value that should have been using a define.

@rjbrown2 rjbrown2 added the enhancement New feature or request label Dec 7, 2021
@rjbrown2 rjbrown2 self-assigned this Dec 7, 2021
@rjbrown2
Copy link
Contributor Author

rjbrown2 commented Dec 7, 2021

Modified the last push to work on collab_main branch. It was currently set up to only work on the unit test branch. Additional branches can be added if so desired.

Copy link
Contributor

@IbraheemYSaleh IbraheemYSaleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem fine to me. Good to merge.

@rjbrown2 rjbrown2 merged commit 5c822c9 into collab_main Dec 7, 2021
@rjbrown2 rjbrown2 deleted the ci_additions branch December 7, 2021 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants