Build changes #39
Merged
Build changes #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbrown2
requested review from
jlucas9,
szemerick,
IbraheemYSaleh and
dccutrig
dccutrig
approved these changes
Dec 21, 2021
Added debug and normal builds without MYSQL
IbraheemYSaleh
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add debug mysql build additions, as well as non-debug mysql changes. This will help to make sure that changes are not breaking the mysql build.
Additionally, added code-coverage capabilities to CMake. This will require the user to have installed gcov and lcov. Currently this is only able to be run locally. However, I am going to look into adding this to the build to allow for results to be shown directly within Github.