Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IC - 20200226 #138

Merged
merged 2 commits into from
Feb 28, 2020
Merged

IC - 20200226 #138

merged 2 commits into from
Feb 28, 2020

Conversation

astrogeco
Copy link
Contributor

Describe the contribution
Fix #66

Testing performed
Steps taken to test the contribution:

Current CI passes
Test 4 in Enhanced CI in https://github.com/nasa/cFS/pull/40

Expected behavior changes
PR #116 - simplifies array handling in 'fsw/mcp750-vxworks/src/cfe_psp_memory.c'

System(s) tested on
CI: Ubuntu 18.04

Additional context
N/A

Third party code
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Gerardo E. Cruz-Ortiz - NASA/GSFC

@astrogeco astrogeco mentioned this pull request Feb 26, 2020
@astrogeco astrogeco requested a review from a user February 26, 2020 21:46
@astrogeco
Copy link
Contributor Author

@acudmore Can you check if this needs to be tested in other platforms?

@astrogeco
Copy link
Contributor Author

CCB 20200226 - Check if tests needed on other platforms. If CI tests are enough then approve.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve based on visual inspection. It would be nice to verify that it compiles and runs on vxWorks/MCP750, but I don't know if it's worth holding up the merge of the IC.

Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I built this IC has part of testing a different change, and can confirm that it builds OK for the MCP750 vxworks6.9 toolchain. Did not execute the binary yet, however.

@astrogeco astrogeco added the CCB:Approved Indicates Approval by CCB label Feb 28, 2020
@astrogeco astrogeco merged commit 440e31a into master Feb 28, 2020
@skliper skliper added this to the 1.5.0 milestone Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates Approval by CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use (foo), not &(foo[0]), where appropriate
4 participants