PSP Integration candidate: 2021-04-02 #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A number of cleanup items related to the PSP memory range API - Make the table itself an internal object - should only be accessed via the PSP API. - Update to use size_t instead of uint32 - Update the Linux/RTEMS implementation to use full range (SIZE_MAX).
This global config structure is not really necessary. The original intent was to allow dependents (e.g. CFE) to get vars at runtime but keep them stored within PSP. However for all those cases where CFE needs PSP info, an API function is defined to get the info. There should not be any need to read this variable directly.
Fix #280, remove psp configdata global object
astrogeco
force-pushed
the
integration-candidate
branch
from
282ae92
to
511392c
Compare
Fix #281, cleanup memory range table
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 2, 2021
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 2, 2021
*Submodule ICs:* nasa/cFE#1279, nasa/PSP#288 *Submodule IC Contents:* nasa/cFE#1274 - Fix #1273, remove PspConfig global object nasa/cFE#1278 - Fix #1277, ZeroCopy typo in ReadMe nasa/PSP#287 - Fix #280, remove psp configdata global object nasa/PSP#283 - Fix #281, cleanup memory range table
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 2, 2021
*Submodule ICs:* nasa/cFE#1279, nasa/PSP#288 *Contents:* nasa/cFE#1274 - Fix #1273, remove PspConfig global object nasa/cFE#1278 - Fix #1277, ZeroCopy typo in ReadMe nasa/PSP#287 - Fix #280, remove psp configdata global object nasa/PSP#283 - Fix #281, cleanup memory range table
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Apr 2, 2021
*Submodule ICs:* nasa/cFE#1279, nasa/PSP#288 *Contents:* nasa/cFE#1274 - Fix #1273, remove PspConfig global object nasa/cFE#1278 - Fix #1277, ZeroCopy typo in ReadMe nasa/PSP#287 - Fix #280, remove psp configdata global object nasa/PSP#283 - Fix #281, cleanup memory range table
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description and Behavior Impacts
PR #287
Fix #280, remove psp configdata global object
Removes unnecessary global config structure
Target_PspConfigDataand associated elements infavor of the new version API.PR #283
Fix #281, cleanup memory range table
The mem pool stats TLM command now works on 64-bit Linux and sends out the expected telemetry packet.
Converts
CFE_PSP_MemoryTableto internal object (instead of external) that should only be accessed via the PSP API. Replaceuint32s withsize_t. Use full range (SIZE_MAX) in the Linux/RTEMS implementation.Testing
psp https://github.com/nasa/PSP/pull/288/checks
bundle https://github.com/nasa/cFS/pull/233/checks
Context
Part of nasa/cFS#233
Authors
@jphickey