-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miro soracore ubuntu20 #307
Conversation
@@ -88,15 +88,15 @@ add_library(dds_ros_bridge | |||
) | |||
target_compile_definitions(dds_ros_bridge PUBLIC ${RTIDDS_DEFINE_FLAGS}) | |||
add_dependencies(dds_ros_bridge ${catkin_EXPORTED_TARGETS}) | |||
target_link_libraries(dds_ros_bridge rapidIo ${Boost_LIBRARIES} ${catkin_LIBRARIES}) | |||
target_link_libraries(dds_ros_bridge rapidIo Qt5::Xml ${Boost_LIBRARIES} ${catkin_LIBRARIES}) | |||
|
|||
|
|||
add_library(astrobee_astrobee_bridge | |||
src/astrobee_astrobee_bridge.cc | |||
) | |||
target_compile_definitions(astrobee_astrobee_bridge PUBLIC ${RTIDDS_DEFINE_FLAGS}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, but not sure why we have a separate astrobee_astrobee_bridge library when the dds_ros_bridge includes it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure... do you know @kbrowne15 @rgarciaruiz ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ruben is looking into it :)
Let's test on the robot first and then come back to this. |
tested on the robot and dds nodes crashed, meaning we might beed to update the debians at the same time as we merge this in |
273b625
to
a5f6e96
Compare
I added IFs to make it qt4 on older versions, not a very cmake code but tested on the robot and in ubuntu20 |
Compiling miro, soracore and astrobee with qt5, working in ubuntu 16-20